| Message ID | 20200330173220.28572-1-sean.j.christopherson@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [for_v29] selftest/sgx: Remove printing of segments during enclave load | expand |
On Mon, Mar 30, 2020 at 10:32:20AM -0700, Sean Christopherson wrote: > Don't print the enclave's segment information during load. Most > failures are unlikely to be related to the loader/protections, and > without context, e.g. printing what the numbers mean, the output is > unhelpful and distracting. > > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> > --- > tools/testing/selftests/sgx/load.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tools/testing/selftests/sgx/load.c b/tools/testing/selftests/sgx/load.c > index 35a2d7a47dd5..1a10b92adfa0 100644 > --- a/tools/testing/selftests/sgx/load.c > +++ b/tools/testing/selftests/sgx/load.c > @@ -204,9 +204,6 @@ bool encl_load(const char *path, struct encl *encl) > seg->offset = (phdr->p_offset & PAGE_MASK) - src_offset; > seg->size = (phdr->p_filesz + PAGE_SIZE - 1) & PAGE_MASK; > > - printf("0x%016lx 0x%016lx 0x%02x\n", seg->offset, seg->size, > - seg->prot); > - It is really useful to have this always there since it reveals immediately bunch of regressions when touching the loader. It has shown already useful at least a dozen of times. Thus, I don't seriously want to remove it. I suggest that you add something like "--print-layout" to the test program. I'm cool with *optionally* having the print. You appreciate to have it there when something goes wrong. /Jarkko
diff --git a/tools/testing/selftests/sgx/load.c b/tools/testing/selftests/sgx/load.c index 35a2d7a47dd5..1a10b92adfa0 100644 --- a/tools/testing/selftests/sgx/load.c +++ b/tools/testing/selftests/sgx/load.c @@ -204,9 +204,6 @@ bool encl_load(const char *path, struct encl *encl) seg->offset = (phdr->p_offset & PAGE_MASK) - src_offset; seg->size = (phdr->p_filesz + PAGE_SIZE - 1) & PAGE_MASK; - printf("0x%016lx 0x%016lx 0x%02x\n", seg->offset, seg->size, - seg->prot); - j++; }
Don't print the enclave's segment information during load. Most failures are unlikely to be related to the loader/protections, and without context, e.g. printing what the numbers mean, the output is unhelpful and distracting. Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> --- tools/testing/selftests/sgx/load.c | 3 --- 1 file changed, 3 deletions(-)