diff mbox series

x86/sgx: simplify the return expression of sgx_drv_init()

Message ID 20220505021659.54210-1-chi.minghao@zte.com.cn (mailing list archive)
State New, archived
Headers show
Series x86/sgx: simplify the return expression of sgx_drv_init() | expand

Commit Message

CGEL May 5, 2022, 2:16 a.m. UTC 
From: Minghao Chi <chi.minghao@zte.com.cn>

Simplify the return expression.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
 arch/x86/kernel/cpu/sgx/driver.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Dave Hansen May 5, 2022, 5:31 p.m. UTC | #1 
On 5/4/22 19:16, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Simplify the return expression.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>

Folks, I'd really encourage you to spend your time elsewhere.  These
"cleanup" or "simplify" patches as a whole have high rates of bugs.  I
don't trust them.  Plus, they don't really make the code easier to
understand.
Jarkko Sakkinen May 6, 2022, 10:30 p.m. UTC | #2 
On Thu, May 05, 2022 at 10:31:41AM -0700, Dave Hansen wrote:
> On 5/4/22 19:16, cgel.zte@gmail.com wrote:
> > From: Minghao Chi <chi.minghao@zte.com.cn>
> > 
> > Simplify the return expression.
> > 
> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Folks, I'd really encourage you to spend your time elsewhere.  These
> "cleanup" or "simplify" patches as a whole have high rates of bugs.  I
> don't trust them.  Plus, they don't really make the code easier to
> understand.

I agree. I get this kind of clean up in the context of doing something
to the functionality (in the same path) but it does not live by its own.

Plus, these type of patches add to the effort backporting fixes.

BR, Jarkko
diff mbox series

Patch

diff --git a/arch/x86/kernel/cpu/sgx/driver.c b/arch/x86/kernel/cpu/sgx/driver.c
index aa9b8b868867..dffb271f4edb 100644
--- a/arch/x86/kernel/cpu/sgx/driver.c
+++ b/arch/x86/kernel/cpu/sgx/driver.c
@@ -148,7 +148,6 @@  int __init sgx_drv_init(void)
 	unsigned int eax, ebx, ecx, edx;
 	u64 attr_mask;
 	u64 xfrm_mask;
-	int ret;
 
 	if (!cpu_feature_enabled(X86_FEATURE_SGX_LC))
 		return -ENODEV;
@@ -172,9 +171,5 @@  int __init sgx_drv_init(void)
 		sgx_xfrm_reserved_mask = ~xfrm_mask;
 	}
 
-	ret = misc_register(&sgx_dev_enclave);
-	if (ret)
-		return ret;
-
-	return 0;
+	return misc_register(&sgx_dev_enclave);
 }