diff mbox series

[v2] selftests/sgx: Ignore OpenSSL 3.0 deprecated functions warning

Message ID 20220812180714.566257-1-kristen@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series [v2] selftests/sgx: Ignore OpenSSL 3.0 deprecated functions warning | expand

Commit Message

Kristen Carlson Accardi Aug. 12, 2022, 6:07 p.m. UTC
OpenSSL 3.0 deprecates some of the functions used in the SGX
selftests, causing build errors on new distros. For now ignore
the warnings until support for the functions is no longer
available and mark FIXME so that it can be clear this should
be removed at some point.

Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com>
---
 tools/testing/selftests/sgx/sigstruct.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Jarkko Sakkinen Aug. 14, 2022, 7:22 p.m. UTC | #1
On Fri, Aug 12, 2022 at 11:07:13AM -0700, Kristen Carlson Accardi wrote:
> OpenSSL 3.0 deprecates some of the functions used in the SGX
> selftests, causing build errors on new distros. For now ignore
> the warnings until support for the functions is no longer
> available and mark FIXME so that it can be clear this should
> be removed at some point.
> 
> Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com>
> ---
>  tools/testing/selftests/sgx/sigstruct.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tools/testing/selftests/sgx/sigstruct.c b/tools/testing/selftests/sgx/sigstruct.c
> index 50c5ab1aa6fa..a07896a46364 100644
> --- a/tools/testing/selftests/sgx/sigstruct.c
> +++ b/tools/testing/selftests/sgx/sigstruct.c
> @@ -17,6 +17,12 @@
>  #include "defines.h"
>  #include "main.h"
>  
> +/*
> + * FIXME: OpenSSL 3.0 has deprecated some functions. For now just ignore
> + * the warnings.
> + */
> +#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
> +
>  struct q1q2_ctx {
>  	BN_CTX *bn_ctx;
>  	BIGNUM *m;
> -- 
> 2.36.1
> 

Thank you.


Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko
Shuah Khan Aug. 15, 2022, 10:51 p.m. UTC | #2
On 8/14/22 1:22 PM, Jarkko Sakkinen wrote:
> On Fri, Aug 12, 2022 at 11:07:13AM -0700, Kristen Carlson Accardi wrote:
>> OpenSSL 3.0 deprecates some of the functions used in the SGX
>> selftests, causing build errors on new distros. For now ignore
>> the warnings until support for the functions is no longer
>> available and mark FIXME so that it can be clear this should
>> be removed at some point.
>>
>> Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com>
>> ---
>>   tools/testing/selftests/sgx/sigstruct.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/tools/testing/selftests/sgx/sigstruct.c b/tools/testing/selftests/sgx/sigstruct.c
>> index 50c5ab1aa6fa..a07896a46364 100644
>> --- a/tools/testing/selftests/sgx/sigstruct.c
>> +++ b/tools/testing/selftests/sgx/sigstruct.c
>> @@ -17,6 +17,12 @@
>>   #include "defines.h"
>>   #include "main.h"
>>   
>> +/*
>> + * FIXME: OpenSSL 3.0 has deprecated some functions. For now just ignore
>> + * the warnings.
>> + */
>> +#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
>> +
>>   struct q1q2_ctx {
>>   	BN_CTX *bn_ctx;
>>   	BIGNUM *m;
>> -- 
>> 2.36.1
>>
> 
> Thank you.
> 
> 
> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> BR, Jarkko
> 

Thank you both.

Applied for rc2/3

thanks,
-- Shuah
diff mbox series

Patch

diff --git a/tools/testing/selftests/sgx/sigstruct.c b/tools/testing/selftests/sgx/sigstruct.c
index 50c5ab1aa6fa..a07896a46364 100644
--- a/tools/testing/selftests/sgx/sigstruct.c
+++ b/tools/testing/selftests/sgx/sigstruct.c
@@ -17,6 +17,12 @@ 
 #include "defines.h"
 #include "main.h"
 
+/*
+ * FIXME: OpenSSL 3.0 has deprecated some functions. For now just ignore
+ * the warnings.
+ */
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+
 struct q1q2_ctx {
 	BN_CTX *bn_ctx;
 	BIGNUM *m;