mbox series

[for-next,0/4] io_uring: cleanup allow_overflow on post_cqe

Message ID 20221107125236.260132-1-dylany@meta.com (mailing list archive)
Headers show
Series io_uring: cleanup allow_overflow on post_cqe | expand

Message

Dylan Yudaken Nov. 7, 2022, 12:52 p.m. UTC
Previously, CQE ordering could be broken in multishot if there was an
overflow, and so the multishot was stopped in overflow. However since
Pavel's change in commit aa1df3a360a0 ("io_uring: fix CQE reordering"),
there is no risk of out of order completions being received by userspace.

So we can now clean up this code.

Dylan Yudaken (4):
  io_uring: revert "io_uring fix multishot accept ordering"
  io_uring: revert "io_uring: fix multishot poll on overflow"
  io_uring: allow multishot recv CQEs to overflow
  io_uring: remove allow_overflow parameter

 io_uring/io_uring.c | 13 ++++---------
 io_uring/io_uring.h |  6 ++----
 io_uring/msg_ring.c |  4 ++--
 io_uring/net.c      | 19 ++++++-------------
 io_uring/poll.c     |  6 ++----
 io_uring/rsrc.c     |  4 ++--
 6 files changed, 18 insertions(+), 34 deletions(-)


base-commit: 765d0e263fccc8b22efef8258c3260e9d0ecf632

Comments

Jens Axboe Nov. 7, 2022, 8:18 p.m. UTC | #1
On Mon, 7 Nov 2022 04:52:32 -0800, Dylan Yudaken wrote:
> Previously, CQE ordering could be broken in multishot if there was an
> overflow, and so the multishot was stopped in overflow. However since
> Pavel's change in commit aa1df3a360a0 ("io_uring: fix CQE reordering"),
> there is no risk of out of order completions being received by userspace.
> 
> So we can now clean up this code.
> 
> [...]

Applied, thanks!

[1/4] io_uring: revert "io_uring fix multishot accept ordering"
      commit: 01661287389d6ab44150c4c05ff3910a12681790
[2/4] io_uring: revert "io_uring: fix multishot poll on overflow"
      commit: 7bf3f5a6acfb5c2daaf7657b28c73eee7ed5db8b
[3/4] io_uring: allow multishot recv CQEs to overflow
      commit: beecb96e259f0d8e59f8bbebc6b007084f87d66d
[4/4] io_uring: remove allow_overflow parameter
      commit: 6488182c989ac73a18dd83539d57a5afd52815ef

Best regards,