[v4,0/2] io_uring: add support for ftruncate

Message

Tony Solomonik Jan. 23, 2024, 10:33 p.m. UTC

This patch adds support for doing truncate through io_uring, eliminating
the need for applications to roll their own thread pool or offload
mechanism to be able to do non-blocking truncates.

Tony Solomonik (2):
  Add ftruncate_file that truncates a struct file
  io_uring: add support for ftruncate

 fs/internal.h                 |  1 +
 fs/open.c                     | 53 ++++++++++++++++++-----------------
 include/uapi/linux/io_uring.h |  1 +
 io_uring/Makefile             |  2 +-
 io_uring/opdef.c              | 10 +++++++
 io_uring/truncate.c           | 48 +++++++++++++++++++++++++++++++
 io_uring/truncate.h           |  4 +++
 7 files changed, 93 insertions(+), 26 deletions(-)
 create mode 100644 io_uring/truncate.c
 create mode 100644 io_uring/truncate.h


base-commit: d3fa86b1a7b4cdc4367acacea16b72e0a200b3d7

Comments

Jens Axboe Jan. 23, 2024, 11:24 p.m. UTC | #1

On 1/23/24 3:33 PM, Tony Solomonik wrote:
> This patch adds support for doing truncate through io_uring, eliminating
> the need for applications to roll their own thread pool or offload
> mechanism to be able to do non-blocking truncates.

All looks go to me now! But I think you should send out a v5 and cc
[e-mail] and christian Brauner <[e-mail]>
to get the fs internal bits reviewed and vetted.

Jens Axboe Jan. 23, 2024, 11:40 p.m. UTC | #2

On 1/23/24 4:26 PM, Tony Solomonik wrote:
> Sure I can do that tomorrow (not near my computer anymore).
> 
> By the way, why not just reply with CC to the ones you mentioned, but
> do a v5 instead?

It's harder to read the patch that way, right thing to do is really to
CC the right people from the get-go. You then also get complications of
people replying to the original patch without those folks CC'ed, and
split conversations and missed context that way.

Yeah email sucks...