[5.19,0/3] poll fixes

Message

Pavel Begunkov June 21, 2022, 11 p.m. UTC

Several poll and apoll fixes for 5.19. I don't know if problems in 2-3
were occuring prior to "io_uring: poll rework", but let's at least
back port it to that point.

I'll also be sending another clean up series for 5.20.

Pavel Begunkov (3):
  io_uring: fail links when poll fails
  io_uring: fix wrong arm_poll error handling
  io_uring: fix double poll leak on repolling

 fs/io_uring.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Jens Axboe June 22, 2022, 3:36 a.m. UTC | #1

On 6/21/22 5:00 PM, Pavel Begunkov wrote:
> Several poll and apoll fixes for 5.19. I don't know if problems in 2-3
> were occuring prior to "io_uring: poll rework", but let's at least
> back port it to that point.
> 
> I'll also be sending another clean up series for 5.20.

Looks good to me, a few comments in the patches. As mentioned privately,
I think we should write a dummy char driver that allows us to exercise
all types of poll (single, poll, pollfree, etc) and be able to trigger
the error paths with it too. I'll give that a shot. We can probably
just make it a debugfs file or something like that, and have it be
configurable too as a debug option for test purposes.

Jens Axboe June 22, 2022, 2:59 p.m. UTC | #2

On Wed, 22 Jun 2022 00:00:34 +0100, Pavel Begunkov wrote:
> Several poll and apoll fixes for 5.19. I don't know if problems in 2-3
> were occuring prior to "io_uring: poll rework", but let's at least
> back port it to that point.
> 
> I'll also be sending another clean up series for 5.20.
> 
> Pavel Begunkov (3):
>   io_uring: fail links when poll fails
>   io_uring: fix wrong arm_poll error handling
>   io_uring: fix double poll leak on repolling
> 
> [...]

Applied, thanks!

[1/3] io_uring: fail links when poll fails
      commit: c487a5ad48831afa6784b368ec40d0ee50f2fe1b
[2/3] io_uring: fix wrong arm_poll error handling
      commit: 9d2ad2947a53abf5e5e6527a9eeed50a3a4cbc72
[3/3] io_uring: fix double poll leak on repolling
      commit: c0737fa9a5a5cf5a053bcc983f72d58919b997c6

Best regards,