mbox series

[00/11] clean up req free and CQ locking

Message ID cover.1687518903.git.asml.silence@gmail.com (mailing list archive)
Headers show
Series clean up req free and CQ locking | expand

Message

Pavel Begunkov June 23, 2023, 11:23 a.m. UTC
Patches 1-5 are cleaning how we free requests.
Patches 7-11 brush CQ / ->completion_lock locking 

Pavel Begunkov (11):
  io_uring: open code io_put_req_find_next
  io_uring: remove io_free_req_tw
  io_uring: inline io_dismantle_req()
  io_uring: move io_clean_op()
  io_uring: don't batch task put on reqs free
  io_uring: remove IOU_F_TWQ_FORCE_NORMAL
  io_uring: kill io_cq_unlock()
  io_uring: fix acquire/release annotations
  io_uring: inline __io_cq_unlock
  io_uring: make io_cq_unlock_post static
  io_uring: merge conditional unlock flush helpers

 io_uring/io_uring.c | 223 ++++++++++++++++----------------------------
 io_uring/io_uring.h |   7 +-
 2 files changed, 80 insertions(+), 150 deletions(-)

Comments

Jens Axboe June 23, 2023, 2:26 p.m. UTC | #1
On 6/23/23 5:23?AM, Pavel Begunkov wrote:
> Patches 1-5 are cleaning how we free requests.
> Patches 7-11 brush CQ / ->completion_lock locking 
> 
> Pavel Begunkov (11):
>   io_uring: open code io_put_req_find_next
>   io_uring: remove io_free_req_tw
>   io_uring: inline io_dismantle_req()
>   io_uring: move io_clean_op()
>   io_uring: don't batch task put on reqs free
>   io_uring: remove IOU_F_TWQ_FORCE_NORMAL
>   io_uring: kill io_cq_unlock()
>   io_uring: fix acquire/release annotations
>   io_uring: inline __io_cq_unlock
>   io_uring: make io_cq_unlock_post static
>   io_uring: merge conditional unlock flush helpers
> 
>  io_uring/io_uring.c | 223 ++++++++++++++++----------------------------
>  io_uring/io_uring.h |   7 +-
>  2 files changed, 80 insertions(+), 150 deletions(-)

Was going to say that it's a bit late for 6.5, but looking over the
patches, it's pretty straight forward and mostly just good cleanups and
code reduction. I'll queue it up for 6.5, thanks.
Jens Axboe June 23, 2023, 2:27 p.m. UTC | #2
On Fri, 23 Jun 2023 12:23:20 +0100, Pavel Begunkov wrote:
> Patches 1-5 are cleaning how we free requests.
> Patches 7-11 brush CQ / ->completion_lock locking
> 
> Pavel Begunkov (11):
>   io_uring: open code io_put_req_find_next
>   io_uring: remove io_free_req_tw
>   io_uring: inline io_dismantle_req()
>   io_uring: move io_clean_op()
>   io_uring: don't batch task put on reqs free
>   io_uring: remove IOU_F_TWQ_FORCE_NORMAL
>   io_uring: kill io_cq_unlock()
>   io_uring: fix acquire/release annotations
>   io_uring: inline __io_cq_unlock
>   io_uring: make io_cq_unlock_post static
>   io_uring: merge conditional unlock flush helpers
> 
> [...]

Applied, thanks!

[01/11] io_uring: open code io_put_req_find_next
        commit: 247f97a5f19b642eba5f5c1cf95fc3169326b3fb
[02/11] io_uring: remove io_free_req_tw
        commit: 6ec9afc7f4cba58ab740c59d4c964d9422e2ea82
[03/11] io_uring: inline io_dismantle_req()
        commit: 3b7a612fd0dbd321e15a308b8ac1f8bbf81432bd
[04/11] io_uring: move io_clean_op()
        commit: 5a754dea27fb91a418f7429e24479e4184dee2e3
[05/11] io_uring: don't batch task put on reqs free
        commit: 2fdd6fb5ff958a0f6b403e3f3ffd645b60b2a2b2
[06/11] io_uring: remove IOU_F_TWQ_FORCE_NORMAL
        commit: 91c7884ac9a92ffbf78af7fc89603daf24f448a9
[07/11] io_uring: kill io_cq_unlock()
        commit: f432b76bcc93f36edb3d371f7b8d7881261dd6e7
[08/11] io_uring: fix acquire/release annotations
        commit: 55b6a69fed5df6f88ef0b2ace562b422162beb61
[09/11] io_uring: inline __io_cq_unlock
        commit: ff12617728fa5c7fb5325e164503ca4e936b80bd
[10/11] io_uring: make io_cq_unlock_post static
        commit: 0fdb9a196c6728b51e0e7a4f6fa292d9fd5793de
[11/11] io_uring: merge conditional unlock flush helpers
        commit: c98c81a4ac37b651be7eb9d16f562fc4acc5f867

Best regards,