[0/4] clean up deferred tw wakeups

Message

Pavel Begunkov Jan. 17, 2024, 12:57 a.m. UTC

While reviewing io_req_local_work_add() I haven't found any real problems,
but there are defintely rought edges. Remove one extra smp_mb__after_atomic(),
add comments about how the synchronisation works, and improve mixing lazy with
non-lazy work items.

Pavel Begunkov (4):
  io_uring: adjust defer tw counting
  io_uring: clean up local tw add-wait sync
  io_uring: clean *local_work_add var naming
  io_uring: combine cq_wait_nr checks

 io_uring/io_uring.c | 58 ++++++++++++++++++++++++++++++++-------------
 1 file changed, 42 insertions(+), 16 deletions(-)

Comments

Jens Axboe Jan. 17, 2024, 2:59 p.m. UTC | #1

On Wed, 17 Jan 2024 00:57:25 +0000, Pavel Begunkov wrote:
> While reviewing io_req_local_work_add() I haven't found any real problems,
> but there are defintely rought edges. Remove one extra smp_mb__after_atomic(),
> add comments about how the synchronisation works, and improve mixing lazy with
> non-lazy work items.
> 
> Pavel Begunkov (4):
>   io_uring: adjust defer tw counting
>   io_uring: clean up local tw add-wait sync
>   io_uring: clean *local_work_add var naming
>   io_uring: combine cq_wait_nr checks
> 
> [...]

Applied, thanks!

[1/4] io_uring: adjust defer tw counting
      commit: c5121e33d343f1febaf2098d413a5ddfcaf5998f
[2/4] io_uring: clean up local tw add-wait sync
      commit: 71258398c2b829457859bc778887bf848db35f50
[3/4] io_uring: clean *local_work_add var naming
      commit: b67eaa9683e2a8fea427a4be2603c0f79416407d
[4/4] io_uring: combine cq_wait_nr checks
      commit: 06660b62dbaac1e5170f73b866d13081748d38d1

Best regards,