[0/2] io_uring: minor sqpoll code refactoring

Message

Olivier Langlois July 30, 2024, 9:19 p.m. UTC

the first patch is minor micro-optimization that attempts to avoid a memory
access if by testing a variable to is very likely already in a register

the second patch is also minor but this is much more serious. Without it,
it is possible to have a ring that is configured to enable NAPI busy polling
to NOT perform busy polling in specific conditions.

Olivier Langlois (2):
  io_uring: micro optimization of __io_sq_thread() condition
  io_uring: do the sqpoll napi busy poll outside the submission block

 io_uring/napi.h   | 9 +++++++++
 io_uring/sqpoll.c | 9 +++++----
 2 files changed, 14 insertions(+), 4 deletions(-)

Comments

Jens Axboe Aug. 2, 2024, 1:11 p.m. UTC | #1

On Tue, 30 Jul 2024 17:19:30 -0400, Olivier Langlois wrote:
> the first patch is minor micro-optimization that attempts to avoid a memory
> access if by testing a variable to is very likely already in a register
> 
> the second patch is also minor but this is much more serious. Without it,
> it is possible to have a ring that is configured to enable NAPI busy polling
> to NOT perform busy polling in specific conditions.
> 
> [...]

Applied, thanks!

[1/2] io_uring: micro optimization of __io_sq_thread() condition
      commit: 5fa7a249d5bc847876e04b91133d6b18d5c17140

Best regards,