| Message ID | 0c01d76ff12986c2f48614db8610caff8f78c869.1743500909.git.asml.silence@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] io_uring/kbuf: remove last buf_index manipulation | expand |
On 4/1/25 5:15 AM, Pavel Begunkov wrote: > It doesn't cause any problem, but there is one more place missed where > we set req->buf_index back to bgid. Remove it. Want me to just fold that in with the previous one, it's top of tree anyway and part of the 6.16 series that I haven't even pushed out yet?
On 4/1/25 8:15 AM, Pavel Begunkov wrote: > On 4/1/25 14:13, Jens Axboe wrote: >> On 4/1/25 5:15 AM, Pavel Begunkov wrote: >>> It doesn't cause any problem, but there is one more place missed where >>> we set req->buf_index back to bgid. Remove it. >> >> Want me to just fold that in with the previous one, it's top of >> tree anyway and part of the 6.16 series that I haven't even >> pushed out yet? > > Would be great! Done!
On 4/1/25 14:13, Jens Axboe wrote: > On 4/1/25 5:15 AM, Pavel Begunkov wrote: >> It doesn't cause any problem, but there is one more place missed where >> we set req->buf_index back to bgid. Remove it. > > Want me to just fold that in with the previous one, it's top of > tree anyway and part of the 6.16 series that I haven't even > pushed out yet? Would be great!
diff --git a/io_uring/kbuf.h b/io_uring/kbuf.h index c576a15fbfd4..0798a732e6cb 100644 --- a/io_uring/kbuf.h +++ b/io_uring/kbuf.h @@ -95,7 +95,6 @@ static inline bool io_kbuf_recycle_ring(struct io_kiocb *req) * to monopolize the buffer. */ if (req->buf_list) { - req->buf_index = req->buf_list->bgid; req->flags &= ~(REQ_F_BUFFER_RING|REQ_F_BUFFERS_COMMIT); return true; }
It doesn't cause any problem, but there is one more place missed where we set req->buf_index back to bgid. Remove it. Signed-off-by: Pavel Begunkov <asml.silence@gmail.com> --- io_uring/kbuf.h | 1 - 1 file changed, 1 deletion(-)