| Message ID | 20220611122224.941800-1-hao.xu@linux.dev (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [for-5.20,1/6] io_uring: poll: remove unnecessary req->ref set | expand |
On 6/11/22 13:22, Hao Xu wrote: > From: Hao Xu <howeyxu@tencent.com> > > We now don't need to set req->refcount for poll requests since the > reworked poll code ensures no request release race. Nice, I took this one into the 5.20 branch, cheers https://github.com/isilence/linux/tree/io_uring/for-5.20 > > Signed-off-by: Hao Xu <howeyxu@tencent.com> > --- > io_uring/poll.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/io_uring/poll.c b/io_uring/poll.c > index 0df5eca93b16..73584c4e3e9b 100644 > --- a/io_uring/poll.c > +++ b/io_uring/poll.c > @@ -683,7 +683,6 @@ int io_poll_add_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) > if ((flags & IORING_POLL_ADD_MULTI) && (req->flags & REQ_F_CQE_SKIP)) > return -EINVAL; > > - io_req_set_refcount(req); > req->apoll_events = poll->events = io_poll_parse_events(sqe, flags); > return 0; > }
diff --git a/io_uring/poll.c b/io_uring/poll.c index 0df5eca93b16..73584c4e3e9b 100644 --- a/io_uring/poll.c +++ b/io_uring/poll.c @@ -683,7 +683,6 @@ int io_poll_add_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) if ((flags & IORING_POLL_ADD_MULTI) && (req->flags & REQ_F_CQE_SKIP)) return -EINVAL; - io_req_set_refcount(req); req->apoll_events = poll->events = io_poll_parse_events(sqe, flags); return 0; }