From patchwork Thu Jul 21 14:42:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dylan Yudaken X-Patchwork-Id: 12925304 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D74DC433EF for ; Thu, 21 Jul 2022 14:43:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229810AbiGUOnI (ORCPT ); Thu, 21 Jul 2022 10:43:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229643AbiGUOnG (ORCPT ); Thu, 21 Jul 2022 10:43:06 -0400 Received: from mx0a-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38FD386C06 for ; Thu, 21 Jul 2022 07:43:06 -0700 (PDT) Received: from pps.filterd (m0001303.ppops.net [127.0.0.1]) by m0001303.ppops.net (8.17.1.5/8.17.1.5) with ESMTP id 26KNbDLA007622 for ; Thu, 21 Jul 2022 07:43:05 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=facebook; bh=jHUAHgrEJ+nfgklTktgy3xNwfDMFkupd5aO5OfmBe78=; b=TniFPUrqSQs2U26rj3szl6KdXJ58UoU9Heq1Wp2fYV2p41uzdZLrcxJ0NQya4qw7Hiy4 JRPoF1MA1D0Xr8kG3452+UubOTXCBC/3X+uVZvhxR63zYdu/uBjmL+VexdJX99Mnn24u udnXI6k62VfoTtX936yAhJyI2yJ7O/DUkZw= Received: from maileast.thefacebook.com ([163.114.130.16]) by m0001303.ppops.net (PPS) with ESMTPS id 3hek9pqex7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 21 Jul 2022 07:43:05 -0700 Received: from twshared39111.03.ash8.facebook.com (2620:10d:c0a8:1b::d) by mail.thefacebook.com (2620:10d:c0a8:83::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 21 Jul 2022 07:43:04 -0700 Received: by devbig038.lla2.facebook.com (Postfix, from userid 572232) id 8318D3593BAD; Thu, 21 Jul 2022 07:42:50 -0700 (PDT) From: Dylan Yudaken To: , CC: , , Dylan Yudaken , Ammar Faizi Subject: [PATCH liburing 4/4] skip poll-mshot-overflow on old kernels Date: Thu, 21 Jul 2022 07:42:29 -0700 Message-ID: <20220721144229.1224141-5-dylany@fb.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220721144229.1224141-1-dylany@fb.com> References: <20220721144229.1224141-1-dylany@fb.com> MIME-Version: 1.0 X-FB-Internal: Safe X-Proofpoint-GUID: rIMu2JxUr8UDb4X8o2Y3fdzfgzkPwmZ- X-Proofpoint-ORIG-GUID: rIMu2JxUr8UDb4X8o2Y3fdzfgzkPwmZ- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-21_18,2022-07-20_01,2022-06-22_01 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Older kernels have slightly different behaviour, so rather skip the test on them. Reported-by: Ammar Faizi Signed-off-by: Dylan Yudaken Tested-by: Ammar Faizi --- test/poll-mshot-overflow.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/test/poll-mshot-overflow.c b/test/poll-mshot-overflow.c index 17039f585a77..360df65d2b15 100644 --- a/test/poll-mshot-overflow.c +++ b/test/poll-mshot-overflow.c @@ -59,15 +59,16 @@ int main(int argc, char *argv[]) } struct io_uring_params params = { - .flags = IORING_SETUP_CQSIZE, + /* cheat using SINGLE_ISSUER existence to know if this behaviour + * is updated + */ + .flags = IORING_SETUP_CQSIZE | IORING_SETUP_SINGLE_ISSUER, .cq_entries = 2 }; ret = io_uring_queue_init_params(2, &ring, ¶ms); - if (ret) { - fprintf(stderr, "ring setup failed: %d\n", ret); - return T_EXIT_FAIL; - } + if (ret) + return T_EXIT_SKIP; sqe = io_uring_get_sqe(&ring); if (!sqe) {