| Message ID | 20220803120757.1668278-1-ming.lei@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [V2,1/1] io_uring: pass correct parameters to io_req_set_res | expand |
On Wed, 3 Aug 2022 20:07:57 +0800, Ming Lei wrote: > The two parameters of 'res' and 'cflags' are swapped, so fix it. > Without this fix, 'ublk del' hangs forever. > > Applied, thanks! [1/1] io_uring: pass correct parameters to io_req_set_res commit: ff2557b7224ea9a19fb79eb4bd16d4deef57816a Best regards,
diff --git a/io_uring/uring_cmd.c b/io_uring/uring_cmd.c index 0a421ed51e7e..849d9708d612 100644 --- a/io_uring/uring_cmd.c +++ b/io_uring/uring_cmd.c @@ -46,7 +46,7 @@ void io_uring_cmd_done(struct io_uring_cmd *ioucmd, ssize_t ret, ssize_t res2) if (ret < 0) req_set_fail(req); - io_req_set_res(req, 0, ret); + io_req_set_res(req, ret, 0); if (req->ctx->flags & IORING_SETUP_CQE32) io_req_set_cqe32_extra(req, res2, 0); __io_req_complete(req, 0);
The two parameters of 'res' and 'cflags' are swapped, so fix it. Without this fix, 'ublk del' hangs forever. Cc: Pavel Begunkov <asml.silence@gmail.com> Fixes: de23077eda61f ("io_uring: set completion results upfront") Signed-off-by: Ming Lei <ming.lei@redhat.com> --- V2: - fix 'Fixes tag' as pointed out by Pavel io_uring/uring_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)