From patchwork Fri Aug 19 15:27:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hao Xu X-Patchwork-Id: 12948881 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A566C32771 for ; Fri, 19 Aug 2022 15:30:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349599AbiHSPaO (ORCPT ); Fri, 19 Aug 2022 11:30:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349507AbiHSPaN (ORCPT ); Fri, 19 Aug 2022 11:30:13 -0400 Received: from out1.migadu.com (out1.migadu.com [IPv6:2001:41d0:2:863f::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71702E725B for ; Fri, 19 Aug 2022 08:30:12 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1660923010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lfVJrGZWAV/CxAj15pj4d9hqcvYN2cySKDv1KGRNM08=; b=htF3glim5whu2JDXAWgyvooctoBS8y7YJkmTV4m4JVqD+qM94fSMKvwuua8YPgpiCc1y8Z uVo5olDsyn5S5G2uTUPzoj7aDERj89NbkBxlELzTQBKPX+xZsTE1S34771tFLC7Kb3b7My peayBE07ucLFqI6PkcVAVaT4seAXYXQ= From: Hao Xu To: io-uring@vger.kernel.org Cc: Jens Axboe , Pavel Begunkov , Ingo Molnar , Wanpeng Li Subject: [PATCH 15/19] io_uring: don't use inline completion cache if scheduled Date: Fri, 19 Aug 2022 23:27:34 +0800 Message-Id: <20220819152738.1111255-16-hao.xu@linux.dev> In-Reply-To: <20220819152738.1111255-1-hao.xu@linux.dev> References: <20220819152738.1111255-1-hao.xu@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org From: Hao Xu In uringlet mode, if a worker has been scheduled out during sqe submission, we cannot use inline completion for that sqe. Signed-off-by: Hao Xu --- io_uring/io_uring.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index 0c14b90b8b47..a109dcb48702 100644 --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -1582,7 +1582,14 @@ static int io_issue_sqe(struct io_kiocb *req, unsigned int issue_flags) revert_creds(creds); if (ret == IOU_OK) { - if (issue_flags & IO_URING_F_COMPLETE_DEFER) + bool uringlet = req->ctx->flags & IORING_SETUP_URINGLET; + bool scheduled = false; + + if (uringlet) + scheduled = + io_worker_test_scheduled(current->worker_private); + + if ((issue_flags & IO_URING_F_COMPLETE_DEFER) && !scheduled) io_req_complete_defer(req); else io_req_complete_post(req);