From patchwork Mon Oct 31 13:41:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dylan Yudaken X-Patchwork-Id: 13025936 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FA62FA3746 for ; Mon, 31 Oct 2022 13:41:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231266AbiJaNlw (ORCPT ); Mon, 31 Oct 2022 09:41:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231254AbiJaNlt (ORCPT ); Mon, 31 Oct 2022 09:41:49 -0400 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C41C8101FA for ; Mon, 31 Oct 2022 06:41:48 -0700 (PDT) Received: from pps.filterd (m0044012.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29VDFZhC018811 for ; Mon, 31 Oct 2022 06:41:48 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=s2048-2021-q4; bh=U7L3ksaXouKD+oVaCFiQ0CZIndC7HTcK8vsAc5fbv34=; b=gevDVRfJR1+zZG5vkDeh4ON7TejlkHu96fOSH8yDOIe6HLoNpkBLJbhWscAhbBjgjP/I ORoTnnAzIYbvQRbPNMngakG9fJBgV4STZSCqvrqHqvmDQDQ3lEmAuJqONlzEUTyFWIap fk4zrgSAoDEHlBxo3Js9Z6CHJN9pWFesNC+ZeOcH7s0oAG+KhmtWnSH83BE0t9rbgdP3 6TeOhBHLjygoFYB8+52vwoWYwB2pVP8jTkdpf5N3XRllXOoQ1CH+kPDl4iwouBEmS/Q8 sFl8MhtC4ntx4XprN04PgpJbxxT3gl0DQ5bGb4Q3oljkGOw73DtopVPPaiBwXUbUfMNZ jw== Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3kh1vpwwh9-13 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 31 Oct 2022 06:41:48 -0700 Received: from twshared6758.06.ash9.facebook.com (2620:10d:c085:108::4) by mail.thefacebook.com (2620:10d:c085:11d::4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct 2022 06:41:47 -0700 Received: by devbig038.lla2.facebook.com (Postfix, from userid 572232) id C16DA8A19650; Mon, 31 Oct 2022 06:41:35 -0700 (PDT) From: Dylan Yudaken To: Jens Axboe , Pavel Begunkov CC: , , Dylan Yudaken Subject: [PATCH for-next 05/12] io_uring: add tracing for io_uring_rsrc_retarget Date: Mon, 31 Oct 2022 06:41:19 -0700 Message-ID: <20221031134126.82928-6-dylany@meta.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221031134126.82928-1-dylany@meta.com> References: <20221031134126.82928-1-dylany@meta.com> MIME-Version: 1.0 X-FB-Internal: Safe X-Proofpoint-GUID: vOKVqMwLxcWki8bEWpr85qKhM-JdUIx4 X-Proofpoint-ORIG-GUID: vOKVqMwLxcWki8bEWpr85qKhM-JdUIx4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-31_15,2022-10-31_01,2022-06-22_01 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Add event tracing to show how many poll/wq requests were retargeted Signed-off-by: Dylan Yudaken --- include/trace/events/io_uring.h | 30 ++++++++++++++++++++++++++++++ io_uring/rsrc.c | 2 ++ 2 files changed, 32 insertions(+) diff --git a/include/trace/events/io_uring.h b/include/trace/events/io_uring.h index 936fd41bf147..b47be89dd270 100644 --- a/include/trace/events/io_uring.h +++ b/include/trace/events/io_uring.h @@ -684,6 +684,36 @@ TRACE_EVENT(io_uring_local_work_run, TP_printk("ring %p, count %d, loops %u", __entry->ctx, __entry->count, __entry->loops) ); +/* + * io_uring_rsrc_retarget - ran a rsrc retarget + * + * @ctx: pointer to a io_uring_ctx + * @poll: how many retargeted that were polling + * @wq: how many retargeted that were in the wq + * + */ +TRACE_EVENT(io_uring_rsrc_retarget, + + TP_PROTO(void *ctx, unsigned int poll, unsigned int wq), + + TP_ARGS(ctx, poll, wq), + + TP_STRUCT__entry( + __field(void *, ctx) + __field(unsigned int, poll) + __field(unsigned int, wq) + ), + + TP_fast_assign( + __entry->ctx = ctx; + __entry->poll = poll; + __entry->wq = wq; + ), + + TP_printk("ring %p, poll %u, wq %u", + __entry->ctx, __entry->poll, __entry->wq) +); + #endif /* _TRACE_IO_URING_H */ /* This part must be outside protection */ diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c index 40b37899e943..00402533cee5 100644 --- a/io_uring/rsrc.c +++ b/io_uring/rsrc.c @@ -325,6 +325,8 @@ static void __io_rsrc_retarget_work(struct io_ring_ctx *ctx) ctx->rsrc_cached_refs -= (poll_refs + data.refs); while (unlikely(ctx->rsrc_cached_refs < 0)) io_rsrc_refs_refill(ctx); + + trace_io_uring_rsrc_retarget(ctx, poll_refs, data.refs); } void io_rsrc_retarget_work(struct work_struct *work)