From patchwork Mon Nov 21 10:03:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dylan Yudaken X-Patchwork-Id: 13050594 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5936CC433FE for ; Mon, 21 Nov 2022 10:42:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229547AbiKUKmN (ORCPT ); Mon, 21 Nov 2022 05:42:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229607AbiKUKmM (ORCPT ); Mon, 21 Nov 2022 05:42:12 -0500 Received: from mx0b-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C37DEE0E6 for ; Mon, 21 Nov 2022 02:42:10 -0800 (PST) Received: from pps.filterd (m0148460.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AKNK3o6031066 for ; Mon, 21 Nov 2022 02:42:10 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=s2048-2021-q4; bh=qSmCXqBquJPBd/4bCImrTAvqiQHok6YchcnHrDYQvYI=; b=LWIQr6TtLeoid+UH3bc6e6P+5EVRVv4FDHHB59ReXXCj9UuOUrFBmNSkDT5EK9ekMYNi kK3vIyXtC8gl+rIUJcMzerM6xbg65LSzopsh8i7CIeCuOQI56YNtuaMGyqWEe7l15FKW 8IQrDQzGWycC6DosYJqW2nOQpXLJ85QYCRK56bvQN7I4GjVDToCfiIXXUjgbtdznjjoF cfC0najcIXjUqfmmYUjeS0HYUL6sb2yWo2VwMt1pLaSvG7hnKsScGPkijwTjuZGcGBwg K0E+zPd4VQR2KPEEX4FHqg6no2S7p+XS5495pw/nan3nUxRha4eUSIO4C95tPqG9DAXX Mw== Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3kxwj43p6f-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 21 Nov 2022 02:42:09 -0800 Received: from twshared9088.05.ash9.facebook.com (2620:10d:c085:208::f) by mail.thefacebook.com (2620:10d:c085:11d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 21 Nov 2022 02:42:08 -0800 Received: by devbig038.lla2.facebook.com (Postfix, from userid 572232) id 1ACED9E66F6B; Mon, 21 Nov 2022 02:03:54 -0800 (PST) From: Dylan Yudaken To: Jens Axboe , Pavel Begunkov CC: , , Dylan Yudaken Subject: [PATCH for-next 02/10] io_uring: __io_req_complete should defer if available Date: Mon, 21 Nov 2022 02:03:45 -0800 Message-ID: <20221121100353.371865-3-dylany@meta.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221121100353.371865-1-dylany@meta.com> References: <20221121100353.371865-1-dylany@meta.com> MIME-Version: 1.0 X-FB-Internal: Safe X-Proofpoint-GUID: m6jFbUheQYypzU8c2Ym-9MuCjoJEekSZ X-Proofpoint-ORIG-GUID: m6jFbUheQYypzU8c2Ym-9MuCjoJEekSZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-21_06,2022-11-18_01,2022-06-22_01 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org For consistency always defer completion if specified in the issue flags. Signed-off-by: Dylan Yudaken --- io_uring/io_uring.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index f15aca039db6..208afb944b0c 100644 --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -862,7 +862,10 @@ void io_req_complete_post(struct io_kiocb *req) inline void __io_req_complete(struct io_kiocb *req, unsigned issue_flags) { - io_req_complete_post(req); + if (issue_flags & IO_URING_F_COMPLETE_DEFER) + io_req_complete_defer(req); + else + io_req_complete_post(req); } void io_req_complete_failed(struct io_kiocb *req, s32 res)