From patchwork Wed Nov 23 11:06:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dylan Yudaken X-Patchwork-Id: 13053477 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29455C433FE for ; Wed, 23 Nov 2022 11:11:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237038AbiKWLLP (ORCPT ); Wed, 23 Nov 2022 06:11:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237454AbiKWLKp (ORCPT ); Wed, 23 Nov 2022 06:10:45 -0500 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3957FD08A3 for ; Wed, 23 Nov 2022 03:09:06 -0800 (PST) Received: from pps.filterd (m0044012.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2ANB65dN016531 for ; Wed, 23 Nov 2022 03:09:05 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=s2048-2021-q4; bh=AjHrb9o1Ma8k9hUtX6XDKWMtxRJPGN6YQTuzWdDYyNc=; b=LhkHqLghNziT+b4xefIjkftn1hJA0lCcGwbMywNn0dRszCW3u5TbqwmAAd+AAzj4yDQL g4uV2OuNaOMDCoTRQQjdHNfZCufnUcsYW0w7V+AV7C4io9KLAD1QsCYXtKxHzy/1LXp2 Wde6/S3TDkv8hpGPmNpsFSGyH8yFeeVIOBApKPkWBNHfnFmP4v29mCiRqukHp+eM7K6t 6ueO9jMsSHcmlzcHPHg+1ZrkzqWAMVdxwIkLyXRsWHu8Ssl2K/kWKl6gKUzGCodm6FLG i2q3zYFP1NVrYaHI5OVfloP8pDv5uoyX132BKaobA6UI6gZsqxEFkzem2GcGMEr/bk5c nQ== Received: from maileast.thefacebook.com ([163.114.130.16]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3m1cg3hyey-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 23 Nov 2022 03:09:05 -0800 Received: from twshared41876.03.ash8.facebook.com (2620:10d:c0a8:1b::d) by mail.thefacebook.com (2620:10d:c0a8:83::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 23 Nov 2022 03:09:04 -0800 Received: by devbig038.lla2.facebook.com (Postfix, from userid 572232) id 1B0BFA0804E1; Wed, 23 Nov 2022 03:06:28 -0800 (PST) From: Dylan Yudaken To: Jens Axboe , Pavel Begunkov CC: , , Dylan Yudaken Subject: [PATCH for-next v2 13/13] io_uring: allow multishot polled reqs to defer completion Date: Wed, 23 Nov 2022 03:06:14 -0800 Message-ID: <20221123110614.3297343-14-dylany@meta.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221123110614.3297343-1-dylany@meta.com> References: <20221123110614.3297343-1-dylany@meta.com> MIME-Version: 1.0 X-FB-Internal: Safe X-Proofpoint-ORIG-GUID: dcWpwaLje8gkprnlWmztj9yzNu3kMWS0 X-Proofpoint-GUID: dcWpwaLje8gkprnlWmztj9yzNu3kMWS0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-23_06,2022-11-23_01,2022-06-22_01 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Until now there was no reason for multishot polled requests to defer completions as there was no functional difference. However now this will actually defer the completions, for a performance win. Signed-off-by: Dylan Yudaken --- io_uring/io_uring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index 87ea497590b5..e3f0b4728db3 100644 --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -1816,7 +1816,8 @@ int io_poll_issue(struct io_kiocb *req, bool *locked) io_tw_lock(req->ctx, locked); if (unlikely(req->task->flags & PF_EXITING)) return -EFAULT; - return io_issue_sqe(req, IO_URING_F_NONBLOCK|IO_URING_F_MULTISHOT); + return io_issue_sqe(req, IO_URING_F_NONBLOCK|IO_URING_F_MULTISHOT| + IO_URING_F_COMPLETE_DEFER); } struct io_wq_work *io_wq_free_work(struct io_wq_work *work)