| Message ID | 20230506095502.13401-1-info@bnoordhuis.nl (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | io_uring: undeprecate epoll_ctl support | expand |
Hi, New libuv is indeed in the wild now and CMake uses it, so I end up getting a tonne of: ``` [ 1763.697364] isc-net-0000: epoll_ctl support in io_uring is deprecated and will be removed in a future Linux kernel version. ``` Could you confirm if this patch looks likely to land so we know if it's OK to backport it downstream? Thank you!
On 5/26/23 7:48 PM, Sam James wrote: > Hi, > > New libuv is indeed in the wild now and CMake uses it, so I end up > getting > a tonne of: > ``` > [ 1763.697364] isc-net-0000: epoll_ctl support in io_uring is deprecated > and will be removed in a future Linux kernel version. > ``` > > Could you confirm if this patch looks likely to land so we know if it's > OK > to backport it downstream? Yeah, I think this is the best plan. I was out of town for a bit around when it got reposted and hence missed it, I'll queue it up for this release.
On Sat, 06 May 2023 11:55:02 +0200, Ben Noordhuis wrote: > Libuv recently started using it so there is at least one consumer now. > > Applied, thanks! [1/1] io_uring: undeprecate epoll_ctl support commit: 4ea0bf4b98d66a7a790abb285539f395596bae92 Best regards,
diff --git a/io_uring/epoll.c b/io_uring/epoll.c index 9aa74d2c80bc..89bff2068a19 100644 --- a/io_uring/epoll.c +++ b/io_uring/epoll.c @@ -25,10 +25,6 @@ int io_epoll_ctl_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) { struct io_epoll *epoll = io_kiocb_to_cmd(req, struct io_epoll); - pr_warn_once("%s: epoll_ctl support in io_uring is deprecated and will " - "be removed in a future Linux kernel version.\n", - current->comm); - if (sqe->buf_index || sqe->splice_fd_in) return -EINVAL;
Libuv recently started using it so there is at least one consumer now. Cc: stable@vger.kernel.org Fixes: 61a2732af4b0 ("io_uring: deprecate epoll_ctl support") Link: https://github.com/libuv/libuv/pull/3979 Signed-off-by: Ben Noordhuis <info@bnoordhuis.nl> --- io_uring/epoll.c | 4 ---- 1 file changed, 4 deletions(-)