[net-next,v9,01/20] net: page_pool: don't cast mp param to devmem

Commit Message

David Wei Dec. 18, 2024, 12:37 a.m. UTC

From: Pavel Begunkov <[e-mail]>

page_pool_check_memory_provider() is a generic path and shouldn't assume
anything about the actual type of the memory provider argument. It's
fine while devmem is the only provider, but cast away the devmem
specific binding types to avoid confusion.

Signed-off-by: Pavel Begunkov <[e-mail]>
Signed-off-by: David Wei <[e-mail]>
---
 net/core/page_pool_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jakub Kicinski Dec. 20, 2024, 10:04 p.m. UTC | #1

On Tue, 17 Dec 2024 16:37:27 -0800 David Wei wrote:
> From: Pavel Begunkov <[e-mail]>
> 
> page_pool_check_memory_provider() is a generic path and shouldn't assume
> anything about the actual type of the memory provider argument. It's
> fine while devmem is the only provider, but cast away the devmem
> specific binding types to avoid confusion.

Reviewed-by: Jakub Kicinski <[e-mail]>

Patch

diff --git a/net/core/page_pool_user.c b/net/core/page_pool_user.c
index 48335766c1bf..8d31c71bea1a 100644
--- a/net/core/page_pool_user.c
+++ b/net/core/page_pool_user.c
@@ -353,7 +353,7 @@  void page_pool_unlist(struct page_pool *pool)
 int page_pool_check_memory_provider(struct net_device *dev,
 				    struct netdev_rx_queue *rxq)
 {
-	struct net_devmem_dmabuf_binding *binding = rxq->mp_params.mp_priv;
+	void *binding = rxq->mp_params.mp_priv;
 	struct page_pool *pool;
 	struct hlist_node *n;