| Message ID | 68178467-39c2-adb9-0358-4587ef01cf4a@kernel.dk (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | io_uring/poll: disable level triggered poll | expand |
Hi Jens, > Stefan reports that there are issues with the level triggered > notification. Since we're late in the cycle, and it was introduced for > the 6.0 release, just disable it at prep time and we can bring this > back when Samba is happy with it. > > Reported-by: Stefan Metzmacher <metze@samba.org> > Signed-off-by: Jens Axboe <axboe@kernel.dk> Also reviewed by me. Thanks! metze
On 9/28/22 3:11 PM, Stefan Metzmacher wrote: > Hi Jens, > >> Stefan reports that there are issues with the level triggered >> notification. Since we're late in the cycle, and it was introduced for >> the 6.0 release, just disable it at prep time and we can bring this >> back when Samba is happy with it. >> >> Reported-by: Stefan Metzmacher <metze@samba.org> >> Signed-off-by: Jens Axboe <axboe@kernel.dk> > > Also reviewed by me. Added, thanks!
diff --git a/io_uring/poll.c b/io_uring/poll.c index d5bad0bea6e4..0d9f49c575e0 100644 --- a/io_uring/poll.c +++ b/io_uring/poll.c @@ -857,7 +857,7 @@ int io_poll_add_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) if (sqe->buf_index || sqe->off || sqe->addr) return -EINVAL; flags = READ_ONCE(sqe->len); - if (flags & ~(IORING_POLL_ADD_MULTI|IORING_POLL_ADD_LEVEL)) + if (flags & ~IORING_POLL_ADD_MULTI) return -EINVAL; if ((flags & IORING_POLL_ADD_MULTI) && (req->flags & REQ_F_CQE_SKIP)) return -EINVAL;
Stefan reports that there are issues with the level triggered notification. Since we're late in the cycle, and it was introduced for the 6.0 release, just disable it at prep time and we can bring this back when Samba is happy with it. Reported-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Jens Axboe <axboe@kernel.dk> ---