diff mbox series

[1/1] io_uring: add req flag invariant build assertion

Message ID 9877577b83c25dd78224a8274f799187e7ec7639.1743407551.git.asml.silence@gmail.com (mailing list archive)
State New
Headers show
Series [1/1] io_uring: add req flag invariant build assertion | expand

Commit Message

Pavel Begunkov March 31, 2025, 7:54 a.m. UTC 
We're caching some of file related request flags in a tricky way, put
a build check to make sure flags don't get reshuffled.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
 io_uring/io_uring.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jens Axboe March 31, 2025, 1:07 p.m. UTC | #1 
On Mon, 31 Mar 2025 08:54:00 +0100, Pavel Begunkov wrote:
> We're caching some of file related request flags in a tricky way, put
> a build check to make sure flags don't get reshuffled.
> 
> 

Applied, thanks!

[1/1] io_uring: add req flag invariant build assertion
      commit: 697b2876ac037545ba2761e2ffe9a5c2af6424e6

Best regards,
diff mbox series

Patch

diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index cb17deffd6ca..6df996d01ccf 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -1643,6 +1643,8 @@  io_req_flags_t io_file_get_flags(struct file *file)
 {
 	io_req_flags_t res = 0;
 
+	BUILD_BUG_ON(REQ_F_ISREG_BIT != REQ_F_SUPPORT_NOWAIT_BIT + 1);
+
 	if (S_ISREG(file_inode(file)->i_mode))
 		res |= REQ_F_ISREG;
 	if ((file->f_flags & O_NONBLOCK) || (file->f_mode & FMODE_NOWAIT))