| Message ID | cf6cbd11-e0a6-3d5f-bf93-ddc393e39fdd@kernel.dk (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | io_uring/opdef: remove 'audit_skip' from SENDMSG_ZC | expand |
On Fri, Oct 7, 2022 at 2:28 PM Jens Axboe <axboe@kernel.dk> wrote: > > The msg variants of sending aren't audited separately, so we should not > be setting audit_skip for the zerocopy sendmsg variant either. > > Fixes: 493108d95f14 ("io_uring/net: zerocopy sendmsg") > Reported-by: Paul Moore <paul@paul-moore.com> > Signed-off-by: Jens Axboe <axboe@kernel.dk> Thanks Jens. Reviewed-by: Paul Moore <paul@paul-moore.com>
On Fri, Oct 7, 2022 at 2:35 PM Paul Moore <paul@paul-moore.com> wrote: > On Fri, Oct 7, 2022 at 2:28 PM Jens Axboe <axboe@kernel.dk> wrote: > > > > The msg variants of sending aren't audited separately, so we should not > > be setting audit_skip for the zerocopy sendmsg variant either. > > > > Fixes: 493108d95f14 ("io_uring/net: zerocopy sendmsg") > > Reported-by: Paul Moore <paul@paul-moore.com> > > Signed-off-by: Jens Axboe <axboe@kernel.dk> > > Thanks Jens. > > Reviewed-by: Paul Moore <paul@paul-moore.com> Hi Jens, I just wanted to check on this, are you planning to send this to Linus during the v6.1-rcX cycle?
On Oct 13, 2022, at 4:58 PM, Paul Moore <paul@paul-moore.com> wrote: > > On Fri, Oct 7, 2022 at 2:35 PM Paul Moore <paul@paul-moore.com> wrote: >>> On Fri, Oct 7, 2022 at 2:28 PM Jens Axboe <axboe@kernel.dk> wrote: >>> >>> The msg variants of sending aren't audited separately, so we should not >>> be setting audit_skip for the zerocopy sendmsg variant either. >>> >>> Fixes: 493108d95f14 ("io_uring/net: zerocopy sendmsg") >>> Reported-by: Paul Moore <paul@paul-moore.com> >>> Signed-off-by: Jens Axboe <axboe@kernel.dk> >> >> Thanks Jens. >> >> Reviewed-by: Paul Moore <paul@paul-moore.com> > > Hi Jens, I just wanted to check on this, are you planning to send this > to Linus during the v6.1-rcX cycle? Yes, it was included in the pull sent out earlier today.
On Thu, Oct 13, 2022 at 7:10 PM Jens Axboe <axboe@kernel.dk> wrote: > On Oct 13, 2022, at 4:58 PM, Paul Moore <paul@paul-moore.com> wrote: > > On Fri, Oct 7, 2022 at 2:35 PM Paul Moore <paul@paul-moore.com> wrote: > >>> On Fri, Oct 7, 2022 at 2:28 PM Jens Axboe <axboe@kernel.dk> wrote: > >>> > >>> The msg variants of sending aren't audited separately, so we should not > >>> be setting audit_skip for the zerocopy sendmsg variant either. > >>> > >>> Fixes: 493108d95f14 ("io_uring/net: zerocopy sendmsg") > >>> Reported-by: Paul Moore <paul@paul-moore.com> > >>> Signed-off-by: Jens Axboe <axboe@kernel.dk> > >> > >> Thanks Jens. > >> > >> Reviewed-by: Paul Moore <paul@paul-moore.com> > > > > Hi Jens, I just wanted to check on this, are you planning to send this > > to Linus during the v6.1-rcX cycle? > > Yes, it was included in the pull sent out earlier today. Great, thanks again for your help in taking care of this.
On 10/13/22 5:12 PM, Paul Moore wrote: > On Thu, Oct 13, 2022 at 7:10 PM Jens Axboe <axboe@kernel.dk> wrote: >> On Oct 13, 2022, at 4:58 PM, Paul Moore <paul@paul-moore.com> wrote: >>> On Fri, Oct 7, 2022 at 2:35 PM Paul Moore <paul@paul-moore.com> wrote: >>>>> On Fri, Oct 7, 2022 at 2:28 PM Jens Axboe <axboe@kernel.dk> wrote: >>>>> >>>>> The msg variants of sending aren't audited separately, so we should not >>>>> be setting audit_skip for the zerocopy sendmsg variant either. >>>>> >>>>> Fixes: 493108d95f14 ("io_uring/net: zerocopy sendmsg") >>>>> Reported-by: Paul Moore <paul@paul-moore.com> >>>>> Signed-off-by: Jens Axboe <axboe@kernel.dk> >>>> >>>> Thanks Jens. >>>> >>>> Reviewed-by: Paul Moore <paul@paul-moore.com> >>> >>> Hi Jens, I just wanted to check on this, are you planning to send this >>> to Linus during the v6.1-rcX cycle? >> >> Yes, it was included in the pull sent out earlier today. > > Great, thanks again for your help in taking care of this. Not a problem, thanks for letting me know about it!
diff --git a/io_uring/opdef.c b/io_uring/opdef.c index 2330f6da791e..83dc0f9ad3b2 100644 --- a/io_uring/opdef.c +++ b/io_uring/opdef.c @@ -510,7 +510,6 @@ const struct io_op_def io_op_defs[] = { .needs_file = 1, .unbound_nonreg_file = 1, .pollout = 1, - .audit_skip = 1, .ioprio = 1, .manual_alloc = 1, #if defined(CONFIG_NET)
The msg variants of sending aren't audited separately, so we should not be setting audit_skip for the zerocopy sendmsg variant either. Fixes: 493108d95f14 ("io_uring/net: zerocopy sendmsg") Reported-by: Paul Moore <paul@paul-moore.com> Signed-off-by: Jens Axboe <axboe@kernel.dk> ---