| Message ID | 20230620172533.727504-1-prestwoj@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | PMKID changes | expand |
Hi James, On 6/20/23 12:25, James Prestwood wrote: > v2: > * Pass checksum type to handshake_state_get_pmkid > * Added back in comments regarding AKMs and SHA sizes > * Moved comment regarding preath/SHA1 into station.c > where SHA1 is passed directly > * The older discussion from past patchsets about preauthentication > was mostly left out as it pertains to when you choose preauth > as opposed to the SHA sizes that this patchset is about. > All applied. I changed the wording of patch 3 description slightly since it referred to forthcoming patches that I assume are no longer needed. Please make sure you're fine with the verbiage. Regards, -Denis
On 6/26/23 7:59 PM, Denis Kenzior wrote: > Hi James, > > On 6/20/23 12:25, James Prestwood wrote: >> v2: >> * Pass checksum type to handshake_state_get_pmkid >> * Added back in comments regarding AKMs and SHA sizes >> * Moved comment regarding preath/SHA1 into station.c >> where SHA1 is passed directly >> * The older discussion from past patchsets about preauthentication >> was mostly left out as it pertains to when you choose preauth >> as opposed to the SHA sizes that this patchset is about. >> > > All applied. I changed the wording of patch 3 description slightly > since it referred to forthcoming patches that I assume are no longer > needed. Please make sure you're fine with the verbiage. Yep, LGTM > > Regards, > -Denis >
v2: * Pass checksum type to handshake_state_get_pmkid * Added back in comments regarding AKMs and SHA sizes * Moved comment regarding preath/SHA1 into station.c where SHA1 is passed directly * The older discussion from past patchsets about preauthentication was mostly left out as it pertains to when you choose preauth as opposed to the SHA sizes that this patchset is about. James Prestwood (3): crypto: modify crypto_derive_pmkid to take the length/checksum type handshake: split handshake_state_get_pmkid into separate APIs handshake: handshake: add FT_OVER_8021X AKM for SHA256 PMKID derivation src/crypto.c | 10 ++++---- src/crypto.h | 5 ++-- src/eapol.c | 11 +++------ src/handshake.c | 61 +++++++++++++++++++++++++++++++++++++------------ src/handshake.h | 6 +++-- src/station.c | 10 +++++++- 6 files changed, 70 insertions(+), 33 deletions(-)