mbox series

[v2,00/11] Refactor to unify connect failure code path

Message ID 20240718114514.2916258-1-prestwoj@gmail.com (mailing list archive)
Headers show
Series Refactor to unify connect failure code path | expand

Message

James Prestwood July 18, 2024, 11:45 a.m. UTC
v2:
 * Combined two earlier patch sets (autotests and netdev patch)
 * Call netdev_disconnected() rather than handle the logic manually
 * Add new NETDEV_RESULT_DISCONNECTED to cover any disconnect issued
   by the AP during the connection stage. This cover the 4-way
   handshake or key setting, or anything in between.

There are some additional unrelated patches, and more autotest fixes
that were needed as a result of some prior changes

James Prestwood (11):
  station: print unknown channel number in neighbor report
  netdev: add NETDEV_RESULT_DISCONNECTED
  station: handle NETDEV_RESULT_DISCONNECTED
  station: update logic for handshake failure
  netdev: handle disconnect event during a connection
  eapol: move HANDSHAKE_STARTED_EVENT to eapol_start()
  station: add handshake-started debug event
  auto-t: add clear_events() to IWD class
  auto-t: add reason/test arguments to hostapd deauthenticate
  auto-t: Add deauth during the 4-way handshake test
  auto-t: a few random autotest fixes

 autotests/testEncryptedProfiles/ssidCCMP.psk  |   3 +
 .../disconnect_during_handshake_test.py       | 112 ++++++++++++++++++
 autotests/testPSK-roam/failed_roam_test.py    |   3 +
 autotests/testPSK-roam/ft-psk-ccmp-1.conf     |   2 +-
 autotests/testPSK-roam/ft-psk-ccmp-2.conf     |   2 +-
 autotests/testPSK-roam/ft-psk-ccmp-3.conf     |   2 +-
 autotests/testPSK-roam/main.conf              |   3 +
 .../testPSK-roam/roam_ap_disconnect_test.py   |  12 +-
 autotests/util/hostapd.py                     |   6 +-
 autotests/util/iwd.py                         |   6 +
 src/eapol.c                                   |   4 +-
 src/netdev.c                                  |  19 +--
 src/netdev.h                                  |   2 +
 src/p2p.c                                     |   1 +
 src/station.c                                 |  39 ++++--
 15 files changed, 184 insertions(+), 32 deletions(-)
 create mode 100644 autotests/testPSK-roam/disconnect_during_handshake_test.py

Comments

Denis Kenzior July 18, 2024, 9:11 p.m. UTC | #1
Hi James,

On 7/18/24 6:45 AM, James Prestwood wrote:
> v2:
>   * Combined two earlier patch sets (autotests and netdev patch)
>   * Call netdev_disconnected() rather than handle the logic manually
>   * Add new NETDEV_RESULT_DISCONNECTED to cover any disconnect issued
>     by the AP during the connection stage. This cover the 4-way
>     handshake or key setting, or anything in between.
> 
> There are some additional unrelated patches, and more autotest fixes
> that were needed as a result of some prior changes
> 
> James Prestwood (11):
>    station: print unknown channel number in neighbor report
>    netdev: add NETDEV_RESULT_DISCONNECTED
>    station: handle NETDEV_RESULT_DISCONNECTED
>    station: update logic for handshake failure
>    netdev: handle disconnect event during a connection
>    eapol: move HANDSHAKE_STARTED_EVENT to eapol_start()
>    station: add handshake-started debug event
>    auto-t: add clear_events() to IWD class
>    auto-t: add reason/test arguments to hostapd deauthenticate
>    auto-t: Add deauth during the 4-way handshake test
>    auto-t: a few random autotest fixes
> 
>   autotests/testEncryptedProfiles/ssidCCMP.psk  |   3 +
>   .../disconnect_during_handshake_test.py       | 112 ++++++++++++++++++
>   autotests/testPSK-roam/failed_roam_test.py    |   3 +
>   autotests/testPSK-roam/ft-psk-ccmp-1.conf     |   2 +-
>   autotests/testPSK-roam/ft-psk-ccmp-2.conf     |   2 +-
>   autotests/testPSK-roam/ft-psk-ccmp-3.conf     |   2 +-
>   autotests/testPSK-roam/main.conf              |   3 +
>   .../testPSK-roam/roam_ap_disconnect_test.py   |  12 +-
>   autotests/util/hostapd.py                     |   6 +-
>   autotests/util/iwd.py                         |   6 +
>   src/eapol.c                                   |   4 +-
>   src/netdev.c                                  |  19 +--
>   src/netdev.h                                  |   2 +
>   src/p2p.c                                     |   1 +
>   src/station.c                                 |  39 ++++--
>   15 files changed, 184 insertions(+), 32 deletions(-)
>   create mode 100644 autotests/testPSK-roam/disconnect_during_handshake_test.py
> 

All applied, thanks.

Regards,
-Denis