[1/3] test-runner: exclude 'iwd-rtnl' from being enabled with --log

Commit Message

James Prestwood June 22, 2022, 11:02 p.m. UTC

Enabling this ends up dumping so much logging and, at least with namespaces,
seems to break the logger module and cause really weird behavior, worst of
which is that all processes start dumping to stdout.

This can still be enabled explicitly with --verbose iwd-rtnl, but is turned
off by default when --log is used.
---
 tools/utils.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Denis Kenzior June 22, 2022, 11:37 p.m. UTC | #1

Hi James,

On 6/22/22 18:02, James Prestwood wrote:
> Enabling this ends up dumping so much logging and, at least with namespaces,
> seems to break the logger module and cause really weird behavior, worst of
> which is that all processes start dumping to stdout.
> 
> This can still be enabled explicitly with --verbose iwd-rtnl, but is turned
> off by default when --log is used.
> ---
>   tools/utils.py | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

All applied, thanks.

Regards,
-Denis

Patch

diff --git a/tools/utils.py b/tools/utils.py
index fd51b6e8..e424231f 100644
--- a/tools/utils.py
+++ b/tools/utils.py
@@ -142,13 +142,14 @@  class Process(subprocess.Popen):
 
 	@staticmethod
 	def is_verbose(process, log=True):
+		exclude = ['iwd-rtnl']
 		process = os.path.basename(process)
 
 		if Process.testargs is None:
 			return False
 
 		# every process is verbose when logging is enabled
-		if log and Process.testargs.log:
+		if log and Process.testargs.log and process not in exclude:
 			return True
 
 		if process in Process.testargs.verbose: