diff mbox series

[v4,1/6] auto-t: fix unreliable behavior in testPSK-roam

Message ID 20220822170150.2049490-1-prestwoj@gmail.com (mailing list archive)
State Accepted, archived
Headers show
Series [v4,1/6] auto-t: fix unreliable behavior in testPSK-roam | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
prestwoj/iwd-alpine-ci-fetch success Fetch PR
prestwoj/iwd-ci-fetch success Fetch PR
prestwoj/iwd-ci-gitlint success GitLint
prestwoj/iwd-ci-makedistcheck success Make Distcheck
prestwoj/iwd-alpine-ci-makedistcheck success Make Distcheck
prestwoj/iwd-ci-build success Build - Configure
prestwoj/iwd-alpine-ci-build success Build - Configure
prestwoj/iwd-ci-clang success clang PASS
prestwoj/iwd-ci-makecheckvalgrind success Make Check w/Valgrind
prestwoj/iwd-ci-makecheck success Make Check
prestwoj/iwd-alpine-ci-makecheckvalgrind success Make Check w/Valgrind
prestwoj/iwd-alpine-ci-makecheck success Make Check
prestwoj/iwd-ci-incremental_build success Incremental Build with patches
prestwoj/iwd-alpine-ci-incremental_build success Incremental Build with patches
prestwoj/iwd-ci-testrunner fail test-runner - FAIL:

Commit Message

James Prestwood Aug. 22, 2022, 5:01 p.m. UTC 
The packet loss test had a few problems. First being that the RSSI for
the original BSS was not low enough to change the rank. This meant any
roam was just lucky that the intended BSS was first in the results.

The second problem is timing related, and only happens on UML. Disabling
the rules after the roaming condition sometimes allows IWD to fully
roam and connect before the next state change checks.
---
 autotests/testPSK-roam/connection_test.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Denis Kenzior Aug. 22, 2022, 5:54 p.m. UTC | #1 
Hi James,

On 8/22/22 12:01, James Prestwood wrote:
> The packet loss test had a few problems. First being that the RSSI for
> the original BSS was not low enough to change the rank. This meant any
> roam was just lucky that the intended BSS was first in the results.
> 
> The second problem is timing related, and only happens on UML. Disabling
> the rules after the roaming condition sometimes allows IWD to fully
> roam and connect before the next state change checks.
> ---
>   autotests/testPSK-roam/connection_test.py | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)

I went ahead and applied patches 1-5 in this series.  Andrew still has some 
comments pending on patch 6.

Regards,
-Denis
diff mbox series

Patch

diff --git a/autotests/testPSK-roam/connection_test.py b/autotests/testPSK-roam/connection_test.py
index c926e255..364f75c2 100644
--- a/autotests/testPSK-roam/connection_test.py
+++ b/autotests/testPSK-roam/connection_test.py
@@ -55,16 +55,16 @@  class Test(unittest.TestCase):
         condition = 'obj.state == DeviceState.roaming'
         wd.wait_for_object_condition(device, condition)
 
-        if pkt_loss:
-            self.rule1.enabled = False
-            self.rule2.enabled = False
-
         # Check that iwd is on BSS 1 once out of roaming state and doesn't
         # go through 'disconnected', 'autoconnect', 'connecting' in between
         from_condition = 'obj.state == DeviceState.roaming'
         to_condition = 'obj.state == DeviceState.connected'
         wd.wait_for_object_change(device, from_condition, to_condition)
 
+        if pkt_loss:
+            self.rule1.enabled = False
+            self.rule2.enabled = False
+
         self.bss_hostapd[1].wait_for_event('AP-STA-CONNECTED %s' % device.address)
 
         testutil.test_iface_operstate(device.name)
@@ -197,7 +197,7 @@  class Test(unittest.TestCase):
 
         cls.rule2 = hwsim.rules.create()
         cls.rule2.source = rad0.addresses[0]
-        cls.rule2.signal = -4000
+        cls.rule2.signal = -7000
 
         # Set interface addresses to those expected by hostapd config files
         os.system('ip link set dev "' + cls.bss_hostapd[0].ifname + '" down')