ft: add debugging in __ft_rx_authenticate

Commit Message

James Prestwood June 6, 2023, 3:04 p.m. UTC

If there was some problem during the FT authenticate stage
its nice to know more of what happened: whether the AP didn't
respond, rejected the attempt, or sent an invalid frame/IEs.
---
 src/ft.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

Comments

Denis Kenzior June 6, 2023, 3:35 p.m. UTC | #1

Hi James,

On 6/6/23 10:04, James Prestwood wrote:
> If there was some problem during the FT authenticate stage
> its nice to know more of what happened: whether the AP didn't
> respond, rejected the attempt, or sent an invalid frame/IEs.
> ---
>   src/ft.c | 13 ++++++++++---
>   1 file changed, 10 insertions(+), 3 deletions(-)
> 

Applied, thanks.

Regards,
-Denis

Patch

diff --git a/src/ft.c b/src/ft.c
index 62fb0ae5..e223484b 100644
--- a/src/ft.c
+++ b/src/ft.c
@@ -1000,14 +1000,21 @@  void __ft_rx_authenticate(uint32_t ifindex, const uint8_t *frame,
 
 	if (!ft_parse_authentication_resp_frame(frame, frame_len,
 					info->spa, info->aa, info->aa, 2,
-					&status, &ies, &ies_len))
+					&status, &ies, &ies_len)) {
+		l_debug("Could not parse auth response");
 		return;
+	}
 
-	if (status != 0)
+	if (status != 0) {
+		l_debug("BSS "MAC" rejected FT auth with status=%u",
+				MAC_STR(info->aa), status);
 		goto cancel;
+	}
 
-	if (!ft_parse_ies(info, hs, ies, ies_len))
+	if (!ft_parse_ies(info, hs, ies, ies_len)) {
+		l_debug("Could not parse auth response IEs");
 		goto cancel;
+	}
 
 	info->parsed = true;