diff mbox series

[5/6] auto-t: add comment about FILS rekeys

Message ID 20230619225746.462791-5-prestwoj@gmail.com (mailing list archive)
State Accepted, archived
Headers show
Series [1/6] handshake: add force_sha1 flag to handshake_state_get_pmkid() | expand

Commit Message

James Prestwood June 19, 2023, 10:57 p.m. UTC 
FILS rekeys were fixed in hostapd somewhat recently but older
versions will fail this test. Document that so we don't get
confused when running tests against older hostapd versions.
---
 autotests/testFILS/fils_256_test.py | 4 ++++
 autotests/testFILS/fils_384_test.py | 4 ++++
 2 files changed, 8 insertions(+)

Comments

Denis Kenzior June 20, 2023, 1:54 a.m. UTC | #1 
Hi James,

On 6/19/23 17:57, James Prestwood wrote:
> FILS rekeys were fixed in hostapd somewhat recently but older
> versions will fail this test. Document that so we don't get
> confused when running tests against older hostapd versions.
> ---
>   autotests/testFILS/fils_256_test.py | 4 ++++
>   autotests/testFILS/fils_384_test.py | 4 ++++
>   2 files changed, 8 insertions(+)
> 

Patch 5 & 6 applied, thanks.

Regards,
-Denis
diff mbox series

Patch

diff --git a/autotests/testFILS/fils_256_test.py b/autotests/testFILS/fils_256_test.py
index 7018f0f2..ca20f683 100644
--- a/autotests/testFILS/fils_256_test.py
+++ b/autotests/testFILS/fils_256_test.py
@@ -55,6 +55,10 @@  class Test(unittest.TestCase):
         testutil.test_iface_operstate()
         testutil.test_ifaces_connected(device.name, hapd.ifname)
 
+        #
+        # TODO: If this is failing its likely due to an older hostapd version
+        #       not containing commit 7ee814201b72
+        #
         hapd.rekey(device.address)
 
         device.disconnect()
diff --git a/autotests/testFILS/fils_384_test.py b/autotests/testFILS/fils_384_test.py
index ce8904df..5ff6ec36 100644
--- a/autotests/testFILS/fils_384_test.py
+++ b/autotests/testFILS/fils_384_test.py
@@ -55,6 +55,10 @@  class Test(unittest.TestCase):
         testutil.test_iface_operstate()
         testutil.test_ifaces_connected(device.name, hapd.ifname)
 
+        #
+        # TODO: If this is failing its likely due to an older hostapd version
+        #       not containing commit 7ee814201b72
+        #
         hapd.rekey(device.address)
 
         device.disconnect()