[v3,1/3] dpp-util: store SSID as string, not raw buffer

Commit Message

James Prestwood Nov. 16, 2023, 7:15 p.m. UTC

Nearly every use of the ssid member first has to memcpy it to a
buffer and NULL terminate. Instead just store the ssid as a
string when creating/parsing from JSON.
---
 src/dpp-util.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Denis Kenzior Nov. 17, 2023, 3:48 p.m. UTC | #1

Hi James,

On 11/16/23 13:15, James Prestwood wrote:
> Nearly every use of the ssid member first has to memcpy it to a
> buffer and NULL terminate. Instead just store the ssid as a
> string when creating/parsing from JSON.
> ---
>   src/dpp-util.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

All applied, thanks.

Regards,
-Denis

Patch

diff --git a/src/dpp-util.h b/src/dpp-util.h
index 053caf8c..0724ee44 100644
--- a/src/dpp-util.h
+++ b/src/dpp-util.h
@@ -112,7 +112,7 @@  enum dpp_attribute_type {
 };
 
 struct dpp_configuration {
-	uint8_t ssid[32];
+	char ssid[33];
 	size_t ssid_len;
 	uint32_t akm_suites;
 	char *passphrase;