| Message ID | 20231117160016.81253-1-prestwoj@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [1/2] dpp: fail early if multicast frame registration is unsupported | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| prestwoj/iwd-alpine-ci-fetch | success | Fetch PR |
| prestwoj/iwd-ci-gitlint | success | GitLint |
| prestwoj/iwd-ci-fetch | success | Fetch PR |
| prestwoj/iwd-alpine-ci-makedistcheck | success | Make Distcheck |
| prestwoj/iwd-ci-makedistcheck | success | Make Distcheck |
| prestwoj/iwd-ci-build | success | Build - Configure |
| prestwoj/iwd-alpine-ci-build | success | Build - Configure |
| prestwoj/iwd-alpine-ci-makecheck | pending | makecheck SKIP |
| prestwoj/iwd-alpine-ci-makecheckvalgrind | success | Make Check w/Valgrind |
| prestwoj/iwd-ci-makecheckvalgrind | success | Make Check w/Valgrind |
| prestwoj/iwd-ci-makecheck | success | Make Check |
| prestwoj/iwd-ci-clang | success | clang PASS |
| prestwoj/iwd-ci-incremental_build | success | Incremental Build with patches |
| prestwoj/iwd-alpine-ci-incremental_build | success | Incremental Build with patches |
| prestwoj/iwd-ci-testrunner | fail | test-runner - FAIL: testNetconfig |
Hi James, On 11/17/23 10:00, James Prestwood wrote: > This is done already for DPP, do the same for PKEX. Few drivers > (ath9k upstream, ath10k/11k in progress) support this which is > unfortunate but since a configurator will not work without this > capability its best to fail early. > --- > src/dpp.c | 6 ++++++ > 1 file changed, 6 insertions(+) > Both applied, thanks. Regards, -Denis
diff --git a/src/dpp.c b/src/dpp.c index 0064187b..c7cd4bb3 100644 --- a/src/dpp.c +++ b/src/dpp.c @@ -4362,6 +4362,12 @@ static struct l_dbus_message *dpp_start_pkex_configurator(struct dpp_sm *dpp, dpp->interface != DPP_INTERFACE_UNBOUND) return dbus_error_busy(message); + if (!dpp->mcast_support) { + l_debug("Multicast frame registration not supported, cannot " + "start a configurator"); + return dbus_error_not_supported(message); + } + if (!network || !bss) return dbus_error_not_connected(message);