| Message ID | 20240104125826.599998-1-prestwoj@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | monitor: include unistd.h in main.c | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| prestwoj/iwd-alpine-ci-fetch | success | Fetch PR |
| prestwoj/iwd-ci-gitlint | fail | monitor: include unistd.h in main.c 7: B1 Line exceeds max length (133>80): "monitor/main.c:176:3: error: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Werror=implicit-function-declaration]" |
| prestwoj/iwd-ci-fetch | success | Fetch PR |
| prestwoj/iwd-alpine-ci-makedistcheck | success | Make Distcheck |
| prestwoj/iwd-alpine-ci-incremental_build | success | Incremental build not run PASS |
| prestwoj/iwd-ci-makedistcheck | success | Make Distcheck |
| prestwoj/iwd-ci-incremental_build | success | Incremental build not run PASS |
| prestwoj/iwd-alpine-ci-build | success | Build - Configure |
| prestwoj/iwd-ci-build | success | Build - Configure |
| prestwoj/iwd-ci-makecheckvalgrind | success | Make Check w/Valgrind |
| prestwoj/iwd-ci-makecheck | success | Make Check |
| prestwoj/iwd-ci-clang | success | clang PASS |
| prestwoj/iwd-alpine-ci-makecheckvalgrind | success | Make Check w/Valgrind |
| prestwoj/iwd-alpine-ci-makecheck | success | Make Check |
| prestwoj/iwd-ci-testrunner | fail | test-runner - FAIL: testPSK-roam |
Hi James, On 1/4/24 06:58, James Prestwood wrote: > This fixes a build break on some systems, specifically the > raspberry Pi 3 (ARM): > > monitor/main.c: In function ‘open_packet’: > monitor/main.c:176:3: error: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Werror=implicit-function-declaration] > 176 | close(fd); > | ^~~~~ > | pclose > --- > monitor/main.c | 1 + > 1 file changed, 1 insertion(+) > Applied, thanks. Regards, -Denis
diff --git a/monitor/main.c b/monitor/main.c index e9384e1b..8f354d52 100644 --- a/monitor/main.c +++ b/monitor/main.c @@ -32,6 +32,7 @@ #include <string.h> #include <getopt.h> #include <signal.h> +#include <unistd.h> #include <arpa/inet.h> #include <sys/socket.h> #include <linux/genetlink.h>
This fixes a build break on some systems, specifically the raspberry Pi 3 (ARM): monitor/main.c: In function ‘open_packet’: monitor/main.c:176:3: error: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Werror=implicit-function-declaration] 176 | close(fd); | ^~~~~ | pclose --- monitor/main.c | 1 + 1 file changed, 1 insertion(+)