diff mbox series

build: make missing rst2man non-fatal

Message ID 20240105164705.1071723-1-prestwoj@gmail.com (mailing list archive)
State New
Headers show
Series build: make missing rst2man non-fatal | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
prestwoj/iwd-alpine-ci-fetch success Fetch PR
prestwoj/iwd-ci-gitlint success GitLint
prestwoj/iwd-ci-fetch success Fetch PR
prestwoj/iwd-ci-makedistcheck success Make Distcheck
prestwoj/iwd-ci-incremental_build success Incremental build not run PASS
prestwoj/iwd-ci-build success Build - Configure
prestwoj/iwd-alpine-ci-makedistcheck success Make Distcheck
prestwoj/iwd-alpine-ci-incremental_build success Incremental build not run PASS
prestwoj/iwd-alpine-ci-build success Build - Configure
prestwoj/iwd-ci-makecheckvalgrind success Make Check w/Valgrind
prestwoj/iwd-ci-clang success clang PASS
prestwoj/iwd-ci-makecheck success Make Check
prestwoj/iwd-alpine-ci-makecheckvalgrind success Make Check w/Valgrind
prestwoj/iwd-alpine-ci-makecheck success Make Check
prestwoj/iwd-ci-testrunner success test-runner PASS

Commit Message

James Prestwood Jan. 5, 2024, 4:47 p.m. UTC 
The configure.ac script does not fail to configure if rst2man is missing
but instead sets RUN_RST2MAN depending on if its available, i.e. makes
it an optional requirement. But then in Makefile.am if RUN_RST2MAN is
not set it fails fatally and will not continue with the build.

Instead remove the false return so the build can continue. Another
option would be to put a hard requirement on rst2man and not allow
configure to proceed, but based on the existing logic it did not seem
like this was the original intent.
---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/Makefile.am b/Makefile.am
index b634b730..c8a59f50 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -725,7 +725,7 @@  RST2MAN_PROCESS = $(AM_V_GEN)$(MKDIR_P) $(dir $@) && \
 			--no-generator --no-datestamp $< $@
 else
 RST2MAN_PROCESS = $(AM_V_GEN)test -f $@ || \
-		{ echo "Generated manual page $@ does not exist"; false; }
+		{ echo "Generated manual page $@ does not exist"; }
 endif
 
 %.service: %.service.in Makefile