diff mbox series

[2/2] station: warn on missing scan_bss in station_transition_start

Message ID 20240227211618.318442-2-prestwoj@gmail.com (mailing list archive)
State Accepted, archived
Headers show
Series [1/2] crypto: fix uninitialized variable coverity warning | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
prestwoj/iwd-ci-gitlint success GitLint

Commit Message

James Prestwood Feb. 27, 2024, 9:16 p.m. UTC
This shouldn't be possible in theory since the roam_bss_list being
iterated is a subset of entire scan_bss list station/network has
but to be safe, and catch any issues due to future changes warn on
this condition.
---
 src/station.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/src/station.c b/src/station.c
index 477f444a..641068cc 100644
--- a/src/station.c
+++ b/src/station.c
@@ -2533,6 +2533,8 @@  static void station_transition_start(struct station *station)
 	while ((rbss = l_queue_peek_head(station->roam_bss_list))) {
 		struct scan_bss *bss = network_bss_find_by_addr(
 					station->connected_network, rbss->addr);
+		if (L_WARN_ON(!bss))
+			continue;
 
 		roaming = station_try_next_transition(station, bss,
 							rbss->ft_failed);