| Message ID | 20240315111821.116213-1-prestwoj@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | iwmon: fix incorrect mask printing HE capabilities | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| prestwoj/iwd-alpine-ci-fetch | success | Fetch PR |
| prestwoj/iwd-ci-gitlint | success | GitLint |
| prestwoj/iwd-ci-fetch | success | Fetch PR |
| prestwoj/iwd-alpine-ci-makedistcheck | success | Make Distcheck |
| prestwoj/iwd-alpine-ci-incremental_build | success | Incremental build not run PASS |
| prestwoj/iwd-ci-makedistcheck | success | Make Distcheck |
| prestwoj/iwd-ci-incremental_build | success | Incremental build not run PASS |
| prestwoj/iwd-alpine-ci-build | success | Build - Configure |
| prestwoj/iwd-ci-build | success | Build - Configure |
| prestwoj/iwd-ci-makecheck | success | Make Check |
| prestwoj/iwd-alpine-ci-makecheckvalgrind | success | Make Check w/Valgrind |
| prestwoj/iwd-ci-makecheckvalgrind | success | Make Check w/Valgrind |
| prestwoj/iwd-alpine-ci-makecheck | success | Make Check |
| prestwoj/iwd-ci-clang | success | clang PASS |
| prestwoj/iwd-ci-testrunner | success | test-runner PASS |
Hi James, On 3/15/24 06:18, James Prestwood wrote: > This was changed from too large of a mask (0xff) in an earlier > commit but was masking 5 bits instead of 6. > > Fixes: 121c2c5653 ("monitor: properly mask HE capabilities bitfield") > --- > monitor/nlmon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. Regards, -Denis
diff --git a/monitor/nlmon.c b/monitor/nlmon.c index 6fe63b8d..9fee5bde 100644 --- a/monitor/nlmon.c +++ b/monitor/nlmon.c @@ -1689,7 +1689,7 @@ static void print_ie_he_capabilities(unsigned int level, { const uint8_t *ptr = data; uint8_t width_set = bit_field((ptr + 6)[0], 1, 7); - uint8_t mask = 0x1f; + uint8_t mask = 0x3f; const char *he_channel_width_bitfield[] = { [0] = "40MHz supported (2.4GHz)",
This was changed from too large of a mask (0xff) in an earlier commit but was masking 5 bits instead of 6. Fixes: 121c2c5653 ("monitor: properly mask HE capabilities bitfield") --- monitor/nlmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)