[v2,03/18] unit: fix SAE unit tests

Commit Message

John Brandt May 6, 2024, 12:30 a.m. UTC

Don't mark either client as being the authenticator. In the current unit
tests, both instances act as clients to test functionality. This ensures
the unit does not show an error during the following commits where SAE
for AP mode is added.
---
 unit/test-sae.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Denis Kenzior May 7, 2024, 3:51 p.m. UTC | #1

Hi John,

On 5/5/24 7:30 PM, John Brandt wrote:
> Don't mark either client as being the authenticator. In the current unit
> tests, both instances act as clients to test functionality. This ensures
> the unit does not show an error during the following commits where SAE
> for AP mode is added.
> ---
>   unit/test-sae.c | 3 ---
>   1 file changed, 3 deletions(-)
> 

Applied, thanks.

Regards,
-Denis

Patch

diff --git a/unit/test-sae.c b/unit/test-sae.c
index d9ec6b31..04783d18 100644
--- a/unit/test-sae.c
+++ b/unit/test-sae.c
@@ -421,7 +421,6 @@  static void test_bad_confirm(const void *arg)
 	handshake_state_set_supplicant_address(hs2, aa);
 	handshake_state_set_authenticator_address(hs2, spa);
 	handshake_state_set_passphrase(hs2, passphrase);
-	handshake_state_set_authenticator(hs2, true);
 
 	ap1 = sae_sm_new(hs1, end_to_end_tx_func, test_tx_assoc_func, td1);
 	ap2 = sae_sm_new(hs2, end_to_end_tx_func, test_tx_assoc_func, td2);
@@ -496,7 +495,6 @@  static void test_confirm_after_accept(const void *arg)
 	handshake_state_set_supplicant_address(hs2, aa);
 	handshake_state_set_authenticator_address(hs2, spa);
 	handshake_state_set_passphrase(hs2, passphrase);
-	handshake_state_set_authenticator(hs2, true);
 
 	ap1 = sae_sm_new(hs1, end_to_end_tx_func, test_tx_assoc_func, td1);
 	ap2 = sae_sm_new(hs2, end_to_end_tx_func, test_tx_assoc_func, td2);
@@ -581,7 +579,6 @@  static void test_end_to_end(const void *arg)
 	handshake_state_set_supplicant_address(hs2, aa);
 	handshake_state_set_authenticator_address(hs2, spa);
 	handshake_state_set_passphrase(hs2, passphrase);
-	handshake_state_set_authenticator(hs2, true);
 
 	ap1 = sae_sm_new(hs1, end_to_end_tx_func, test_tx_assoc_func, td1);
 	ap2 = sae_sm_new(hs2, end_to_end_tx_func, test_tx_assoc_func, td2);