diff mbox series

manager: fix UseDefaultInterface warning

Message ID 20240920163614.207001-1-prestwoj@gmail.com (mailing list archive)
State Accepted, archived
Headers show
Series manager: fix UseDefaultInterface warning | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
prestwoj/iwd-alpine-ci-fetch success Fetch PR
prestwoj/iwd-ci-gitlint success GitLint
prestwoj/iwd-ci-fetch success Fetch PR
prestwoj/iwd-alpine-ci-setupell success Prep - Setup ELL
prestwoj/iwd-ci-setupell success Prep - Setup ELL
prestwoj/iwd-ci-makedistcheck success Make Distcheck
prestwoj/iwd-ci-incremental_build success Incremental build not run PASS
prestwoj/iwd-alpine-ci-makedistcheck success Make Distcheck
prestwoj/iwd-alpine-ci-incremental_build success Incremental build not run PASS
prestwoj/iwd-ci-build success Build - Configure
prestwoj/iwd-alpine-ci-build success Build - Configure
prestwoj/iwd-ci-makecheck success Make Check
prestwoj/iwd-ci-makecheckvalgrind success Make Check w/Valgrind
prestwoj/iwd-ci-clang success clang PASS
prestwoj/iwd-alpine-ci-makecheckvalgrind success Make Check w/Valgrind
prestwoj/iwd-alpine-ci-makecheck success Make Check
prestwoj/iwd-ci-testrunner success test-runner PASS

Commit Message

James Prestwood Sept. 20, 2024, 4:36 p.m. UTC 
This logic was incorrect here, we only want to print if the option
is used, not if its unset.
---
 src/manager.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Denis Kenzior Sept. 25, 2024, 2:53 p.m. UTC | #1 
Hi James,

On 9/20/24 11:36 AM, James Prestwood wrote:
> This logic was incorrect here, we only want to print if the option
> is used, not if its unset.
> ---
>   src/manager.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 

Applied, thanks.

Regards,
-Denis
diff mbox series

Patch

diff --git a/src/manager.c b/src/manager.c
index 5bedfcc5..436daa56 100644
--- a/src/manager.c
+++ b/src/manager.c
@@ -894,11 +894,11 @@  static int manager_init(void)
 	}
 
 	if (!l_settings_get_bool(config, "General",
-				"UseDefaultInterface", &use_default)) {
+				"UseDefaultInterface", &use_default))
+		use_default = false;
+	else
 		l_warn("[General].UseDefaultInterface is deprecated, please "
 			"use [DriverQuirks].DefaultInterface instead");
-		use_default = false;
-	}
 
 	return 0;