@@ -110,7 +110,7 @@ Wireless monitor
- Subscribe to all nl80211 multicast groups at startup
- It seems the nlmon packets are limited to actual subscribed mutlicast
+ It seems the nlmon packets are limited to actual subscribed multicast
groups. To get a complete picture of all the nl80211 commands and
events, it is required that iwmon adds membership to all multicast
groups that the nl80211 lists.
@@ -234,7 +234,7 @@ Wireless daemon
- Implement Enrollee Session Overlap Detection after WSC Protocol Run
- WSC Best Practices v2.0.1, Section 3.15 describes an enhacement to detect
+ WSC Best Practices v2.0.1, Section 3.15 describes an enhancement to detect
PBC session overlaps. The Enrollee is asked to perform an extra scan without
the PBC request in the ProbeRequest frames after EAP-WSC completes
successfully. If another AP in PBC mode is found, then a SessionOverlap
@@ -11,7 +11,7 @@ from iwd import IWD
class Test8021xNetwork(unittest.TestCase):
'''
- The bellow test cases excesise the following connection scenarios:
+ The below test cases excesise the following connection scenarios:
Network config is
present at start time: Connect: AutoConnect: Result:
@@ -11,7 +11,7 @@ from iwd import IWD
class TestOpenNetwork(unittest.TestCase):
'''
- The bellow test cases excesise the following connection scenarios:
+ The below test cases excesise the following connection scenarios:
Network config is
present at start time: Connect: AutoConnect: Result:
@@ -11,7 +11,7 @@ from iwd import IWD
class TestWpaNetwork(unittest.TestCase):
'''
- The bellow test cases exercise the following connection scenarios:
+ The below test cases exercise the following connection scenarios:
Network config is
present at start time: Connect: AutoConnect: Result:
@@ -104,7 +104,7 @@ class Test(unittest.TestCase):
self.assertTrue(self.profile_is_encrypted('ssidCCMP.psk'))
- # Tests that a profile that doesn't decrypt wont become a known network
+ # Tests that a profile that doesn't decrypt won't become a known network
def test_decryption_failure(self):
bad_config = \
'''
@@ -12,7 +12,7 @@ from hostapd import HostapdCLI
class TestWpaNetwork(unittest.TestCase):
'''
- The bellow test cases excesise the following connection scenarios:
+ The below test cases excesise the following connection scenarios:
Network config is
present at start time: Connect: AutoConnect: Result:
@@ -12,7 +12,7 @@ from hostapd import HostapdCLI
class TestOpenNetwork(unittest.TestCase):
'''
- The bellow test cases excesise the following connection scenarios:
+ The below test cases excesise the following connection scenarios:
Network config is
present at start time: Connect: AutoConnect: Result:
@@ -12,7 +12,7 @@ from hostapd import HostapdCLI
class TestWpaNetwork(unittest.TestCase):
'''
- The bellow test cases excesise the following connection scenarios:
+ The below test cases excesise the following connection scenarios:
Network config is
present at start time: Connect: AutoConnect: Result:
@@ -11,7 +11,7 @@ from iwd import NetworkType
class TestMFP(unittest.TestCase):
'''
- The bellow test cases excesise the following MFP option setting scenarios:
+ The below test cases excesise the following MFP option setting scenarios:
IWD_MFP: AP_MFP: Result:
0 0 No MFP, connection succeeds
@@ -137,7 +137,7 @@ class Test(unittest.TestCase):
# since (T2 - T1) / 2 is shorter than 60s. It is now about 10s since the last
# renewal or 5s before the next DHCPREQUEST frame that is going to be lost. We'll
# wait T1 seconds, so until about 10s after the failed attempt, we'll check that
- # there was no renewal by that time, just in case, and we'll reenable frame delivery.
+ # there was no renewal by that time, just in case, and we'll re-enable frame delivery.
# We'll then wait another 60s and we should see the lease has been successfully
# renewed some 10 seconds earlier on the 1st DHCPREQUEST retransmission.
#
@@ -17,7 +17,7 @@ from hwsim import Hwsim
class Test(unittest.TestCase):
# Normally the time between a failed roam attempt and the next roam attempt
# is 60 seconds (default RoamRetryInterval). Test that we retry roaming
- # faster if the transision looks like this: LOW [roam] [same bss] HIGH LOW.
+ # faster if the transition looks like this: LOW [roam] [same bss] HIGH LOW.
def test_fast_retry(self):
hwsim = Hwsim()
@@ -15,7 +15,7 @@ from hostapd import HostapdCLI
from hwsim import Hwsim
class Test(unittest.TestCase):
- # Test that we do not periodically retry roaming if the transision looks
+ # Test that we do not periodically retry roaming if the transition looks
# like this: LOW [roam] [new bss] HIGH.
def test_stop_retry(self):
hwsim = Hwsim()
@@ -1481,10 +1481,10 @@ class IWD(AsyncOpAbstract):
@staticmethod
def create_in_storage(file_name, file_content, storage_dir=IWD_STORAGE_DIR):
- fo = open(storage_dir + '/' + file_name, 'w')
+ f = open(storage_dir + '/' + file_name, 'w')
- fo.write(file_content)
- fo.close()
+ f.write(file_content)
+ f.close()
@staticmethod
def _ensure_storage_dir_exists(storage_dir):
@@ -237,7 +237,7 @@ class Wpas:
('' if go_intent is None else ' go_intent=' + str(go_intent)))
self.wait_for_event('OK')
- # Pre-accept the next GO Negotiation Request from this peer to avoid the extra Respone + Request frames
+ # Pre-accept the next GO Negotiation Request from this peer to avoid the extra Response + Request frames
def p2p_authorize(self, peer, pin=None, go_intent=None):
self._rx_data = []
self._ctrl_request('P2P_CONNECT ' + peer['p2p_dev_addr'] + ' ' + ('pbc' if pin is None else pin) +
@@ -186,5 +186,5 @@ void diagnostic_display(struct l_dbus_message_iter *dict,
return;
parse_error:
- display_error("Error parsing dignostics");
+ display_error("Error parsing diagnostics");
}
@@ -219,7 +219,7 @@ static void network_display_inline(const char *margin, const void *data)
display("%s%s %s %s\n", margin, network->name ? network->name : "",
network->type ? network->type : "",
- network->connected ? "connected" : "diconnected");
+ network->connected ? "connected" : "disconnected");
}
static void *network_create(void)
@@ -322,10 +322,10 @@ M18: Use appropriate logging levels
An appropriate log level should be used depending on the type of message
being logged. Logging is done using the l_log APIs in ELL:
-l_error An unexpected condition ocurred. These are generally fatal to the
+l_error An unexpected condition occurred. These are generally fatal to the
current connection/protocol that is running but not generally to IWD's
overall operation.
-l_warn An unexpected, but non-fatal condition ocurred
+l_warn An unexpected, but non-fatal condition occurred
l_notice Should not be used directly. This log level is reserved for special
event type notifications which is handled by iwd_notice().
l_info Information that is expected during normal operation. l_info's use
@@ -135,7 +135,7 @@ Object path /net/connman/iwd/{phy0,phy1,...}/{1,2,...}
void StartConfigurator(object agent_path)
Start a shared code configurator using an agent
- (distingushed by 'agent_path') to obtain the shared
+ (distinguished by 'agent_path') to obtain the shared
code. This method is meant for an automated use case
where a configurator is capable of configuring multiple
enrollees, and distinguishing between them by their
@@ -196,7 +196,7 @@ Methods void Release() [noreply]
string RequestSharedCode(string identifier)
This method gets called when a shared code is requested
- for a particular enrollee, distingushed by the
+ for a particular enrollee, distinguished by the
identifier. The shared code agent should lookup the
identifier and return the shared code, or return an
error if not found.
@@ -5,7 +5,7 @@ credentials for your e.g. cable/cellular provider, or via a dedicated account
like Boingo. Lots of these services also allow you to roam between networks.
The underlying authentication is standard WPA2-Enterprise but Hotspot 2.0 adds a
-'discovery' stage to identifiying networks. This discovery is done using ANQP,
+'discovery' stage to identifying networks. This discovery is done using ANQP,
which queries the network for additional information to determine if the client
has the credentials to connect.
@@ -56,7 +56,7 @@ Methods array(on) GetPeers()
between requested threshold values is a compromise
between resolution and the frequency of system
wakeups and context-switches that are going to be
- occuring to update the client's signal meter. Only
+ occurring to update the client's signal meter. Only
one agent can be registered at any time.
Possible errors: [service].Error.InvalidArguments
@@ -166,7 +166,7 @@ Properties string State [readonly]
object ConnectedAccessPoint [readonly, optional]
- net.connman.iwd.BasicServiceSet object represeting the
+ net.connman.iwd.BasicServiceSet object representing the
BSS the device is currently connected to or to which
a connection is in progress.
@@ -218,7 +218,7 @@ supplicant running IWD:
#~~~~~~~~~~~~~~~~~~~~~~~~~ hw.conf ~~~~~~~~~~~~~~~~~~~~~~~~~
# Lines starting with # are ignored
-# 'SETUP' is a manditory configuration group.
+# 'SETUP' is a mandatory configuration group.
[SETUP]
#
# Total number of radios requested per network setup. This includes
@@ -578,7 +578,7 @@ static int analyze_pcap(const char *pathname)
printf("\n");
printf(" Number of packets: %lu\n", pkt_count);
printf(" Short packets: %lu\n", pkt_short);
- printf(" Tuncated packets: %lu\n", pkt_trunc);
+ printf(" Truncated packets: %lu\n", pkt_trunc);
printf("\n");
printf(" Ethernet packets: %lu\n", pkt_ether);
printf(" PAE packets: %lu\n", pkt_pae);
@@ -1658,7 +1658,7 @@ static void print_ie_vht_capabilities(unsigned int level,
[21] = "TXOP PS",
[22] = "+HTC-VHT Capable",
[23 ... 25] = "Maximum A-MPDU Length Exponent",
- [26 ... 27] = "VHT Link Adapation Capable",
+ [26 ... 27] = "VHT Link Adaptation Capable",
[28] = "RX Antenna Pattern Consistency",
[29] = "TX Antenna Pattern Consistency",
[30 ... 31] = "Extended NSS BW Support",
@@ -234,7 +234,7 @@ uint32_t anqp_request(uint64_t wdev_id, const uint8_t *addr,
request->anqp_cb = cb;
request->anqp_destroy = destroy;
/*
- * WPA3 Specificiation version 3, Section 9.4:
+ * WPA3 Specification version 3, Section 9.4:
* "A STA shall use a randomized dialog token for every new GAS
* exchange."
*/
@@ -79,7 +79,7 @@ struct ap_ops {
void *user_data);
/*
* If not null, writes extra IEs to be added to the outgoing frame of
- * given type and, if it's not a beacon frame, in reponse to a given
+ * given type and, if it's not a beacon frame, in response to a given
* client frame. May also react to the extra IEs in that frame.
* Returns the number of bytes written which must be less than or
* equal to the number returned by .get_extra_ies_len when called
@@ -2001,7 +2001,7 @@ static void dpp_offchannel_timeout(int error, void *user_data)
/*
* We have a pending agent request but it did not arrive in
- * time, we cant assume the enrollee will be waiting around
+ * time, we can't assume the enrollee will be waiting around
* for our response so cancel the request and continue waiting
* for another request
*/
@@ -2722,7 +2722,7 @@ static void dpp_handle_pkex_exchange_response(struct dpp_sm *dpp,
}
if (version && version != dpp->pkex_version) {
- l_debug("PKEX version does not match, igoring");
+ l_debug("PKEX version does not match, ignoring");
return;
}
@@ -3438,7 +3438,7 @@ static void dpp_handle_pkex_commit_reveal_request(struct dpp_sm *dpp,
dpp->peer_boot_public = l_ecc_point_from_data(dpp->curve,
L_ECC_POINT_TYPE_FULL, key, key_len);
if (!dpp->peer_boot_public) {
- l_debug("peers boostrapping key did not validate");
+ l_debug("peers bootstrapping key did not validate");
goto failed;
}
@@ -3598,7 +3598,7 @@ static void dpp_mlme_notify(struct l_genl_msg *msg, void *user_data)
/*
* Only want to handle the no-ACK case. Re-transmitting an ACKed
- * frame likely wont do any good, at least in the case of DPP.
+ * frame likely won't do any good, at least in the case of DPP.
*/
if (!ack)
goto retransmit;
@@ -165,7 +165,7 @@ static void __eap_tls_common_state_reset(struct eap_state *eap)
*
* Drop the cache even if we have no indication that the
* method failed but it just didn't succeed, to handle cases like
- * the server getting stuck and a timout occuring at a higher
+ * the server getting stuck and a timeout occurring at a higher
* layer. The risk is that we may occasionally flush the session
* data when there was only a momentary radio issue, invalid
* phase2 credentials or decision to abort. Those are not hot
@@ -209,7 +209,7 @@ connect to that network.
* - PasswordIdentifier
- string
- An identifer string to be used with the passphrase. This is used for
+ An identifier string to be used with the passphrase. This is used for
WPA3-Personal (SAE) networks if the security has enabled password
identifiers for clients.
* - PreSharedKey
@@ -82,7 +82,7 @@ bool mschap_challenge_response(const uint8_t *challenge,
/**
* Hash the utf8 encoded nt password.
- * It is asumed, that the password is valid utf8!
+ * It is assumed, that the password is valid utf8!
* The rfc says "unicode-char", but never specifies which encoding.
* This function converts the password to ucs-2.
* The example in the code uses LE for the unicode chars, so it is forced here.
@@ -622,7 +622,7 @@ bool netconfig_get_fils_ip_req(struct netconfig *netconfig,
struct ie_fils_ip_addr_request_info *info)
{
/*
- * Fill in the fields used for building the FILS IP Address Assigment
+ * Fill in the fields used for building the FILS IP Address Assignment
* IE during connection if we're configured to do automatic network
* configuration (usually DHCP). If we're configured with static
* values return false to mean the IE should not be sent.
@@ -2169,7 +2169,7 @@ static void netdev_set_pmk(struct handshake_state *hs, const uint8_t *pmk,
struct netdev_handshake_state, super);
struct netdev *netdev = nhs->netdev;
- /* Only relevent for 8021x offload */
+ /* Only relevant for 8021x offload */
if (nhs->type != CONNECTION_TYPE_8021X_OFFLOAD)
return;
@@ -2281,7 +2281,7 @@ static void netdev_qos_map_cb(struct l_genl_msg *msg, void *user_data)
return;
ext_error = l_genl_msg_get_extended_error(msg);
- l_error("Couuld not set QoS Map in kernel: %s",
+ l_error("Could not set QoS Map in kernel: %s",
ext_error ? ext_error : strerror(-err));
}
@@ -2354,7 +2354,7 @@ static void netdev_get_oci_cb(struct l_genl_msg *msg, void *user_data)
done:
if (netdev->ap) {
/*
- * Cant do much here. IWD assumes every kernel/driver supports
+ * Can't do much here. IWD assumes every kernel/driver supports
* this. There is no way of detecting support either.
*/
if (L_WARN_ON(err < 0))
@@ -293,7 +293,7 @@ static void offchannel_mlme_notify(struct l_genl_msg *msg, void *user_data)
* - an event coming from an external ROC request (we just
* happened to have also sent an ROC request).
*
- * We can't tell where the event originated until we recieve our
+ * We can't tell where the event originated until we receive our
* ACK so set early_cookie to track it.
*/
if (i->roc_cmd_id != 0 && l_genl_family_request_sent(nl80211,
@@ -2217,7 +2217,7 @@ static bool p2p_go_negotiation_confirm_cb(const struct mmpdu_header *mpdu,
/*
* Start setting the group up right away and we'll add the
- * client's Configuation Timeout to the WSC start timeout's
+ * client's Configuration Timeout to the WSC start timeout's
* value.
*/
p2p_device_interface_create(dev);
@@ -2549,7 +2549,7 @@ static void p2p_go_negotiation_confirm_done(int error, void *user_data)
/*
* Frame was ACKed. On the GO start setting the group up right
- * away and we'll add the client's Configuation Timeout to the
+ * away and we'll add the client's Configuration Timeout to the
* WSC start timeout's value. On the client wait idly the
* maximum amount of time indicated by the peer in the GO
* Negotiation Response's Configuration Timeout attribute and
@@ -2951,7 +2951,7 @@ static bool p2p_provision_disc_resp_cb(const struct mmpdu_header *mpdu,
}
/*
- * Indended P2P Interface address is optional, we don't have the
+ * Intended P2P Interface address is optional, we don't have the
* BSSID of the group here.
*
* We might want to make sure that Group Formation is false but the
@@ -258,7 +258,7 @@ static struct l_ecc_scalar *sae_pwd_value(const struct l_ecc_curve *curve,
is_in_range = util_secure_fill_with_msb(is_in_range);
/*
- * libell has public Legendre symbol only for l_ecc_scalar, but they
+ * ELL has public Legendre symbol only for l_ecc_scalar, but they
* cannot be created if the coordinate is greater than the p. Hence,
* to avoid control flow dependencies, we replace pwd_value by a dummy
* quadratic non residue if we generate a value >= prime.
@@ -1381,7 +1381,7 @@ static struct handshake_state *station_handshake_setup(struct station *station,
handshake_state_set_vendor_ies(hs, vendor_ies, iov_elems);
/*
- * It can't hurt to try the FILS IP Address Assigment independent of
+ * It can't hurt to try the FILS IP Address Assignment independent of
* which auth-proto is actually used.
*/
if (station->netconfig && netconfig_get_fils_ip_req(station->netconfig,
@@ -1915,7 +1915,7 @@ static void station_reset_connection_state(struct station *station)
/*
* Perform this step last since calling network_disconnected() might
* result in the removal of the network (for example if provisioning
- * a new hidden network fails with an incorrect pasword).
+ * a new hidden network fails with an incorrect password).
*/
if (station->state == STATION_STATE_CONNECTED ||
station->state == STATION_STATE_CONNECTING ||
@@ -3095,7 +3095,7 @@ static void station_roam_timeout_rearm(struct station *station, int seconds)
if (!station->roam_trigger_timeout)
goto new_timeout;
- /* If we cant get the remaining time just create a new timer */
+ /* If we can't get the remaining time just create a new timer */
if (L_WARN_ON(!l_timeout_remaining(station->roam_trigger_timeout,
&remaining))) {
l_timeout_remove(station->roam_trigger_timeout);
@@ -535,7 +535,7 @@ int __storage_decrypt(struct l_settings *settings, const char *ssid,
/*
* Load decrypted data into existing settings. This is not how the API
- * is indended to be used (since this could result in duplicate groups)
+ * is intended to be used (since this could result in duplicate groups)
* but since the Security group was just removed and EncryptedSecurity
* should only contain a Security group its safe to use it this way.
*/
@@ -276,7 +276,7 @@ bool util_ip_prefix_tohl(const char *ip, uint8_t *prefix_out,
/* 'i' will be at most INET_ADDRSTRLEN - 1 */
l_strlcpy(no_prefix, ip, i + 1);
- /* Check if IP preceeding prefix is valid */
+ /* Check if IP preceding prefix is valid */
if (inet_pton(AF_INET, no_prefix, &ia) != 1 || ia.s_addr == 0)
return false;
@@ -2286,7 +2286,7 @@ static void wiphy_dump_after_regdom(struct wiphy *wiphy)
}
/*
- * Another update while dumping wiphy. This next dump should supercede
+ * Another update while dumping wiphy. This next dump should supersede
* the first and not result in a DONE event until this new dump is
* finished. This is because the disabled frequencies are in an unknown
* state and could cause incorrect behavior by any watchers.
@@ -75,7 +75,7 @@ static bool secret_from_file(const char *file)
fd = open(file, O_RDONLY, 0);
if (fd < 0) {
- printf("Cant open %s (%d)\n", file, fd);
+ printf("Can't open %s (%d)\n", file, fd);
return false;
}
@@ -119,7 +119,7 @@ class VirtualRadio(Radio):
'''
A subclass of 'Radio' specific to mac80211_hwsim radios.
- TODO: Using D-Bus to create and destroy radios is more desireable
+ TODO: Using D-Bus to create and destroy radios is more desirable
than the command line.
'''
@@ -400,7 +400,7 @@ class TestContext(Namespace):
# just given to hostapd/IWD as they appear during
# discovery.
#
- # TODO: It may be desireable to map PCI/USB adapters to
+ # TODO: It may be desirable to map PCI/USB adapters to
# specific radX radios specified in the config but
# there are really 2 separate use cases here.
# 1. You want to test a *specific* radio with IWD
@@ -482,7 +482,7 @@ class TestContext(Namespace):
def start_ofono(self):
sim_keys = self.hw_config['SETUP'].get('sim_keys', None)
if not sim_keys:
- print("Ofono not requred")
+ print("Ofono not required")
return
elif sim_keys != 'ofono':
os.environ['IWD_SIM_KEYS'] = sim_keys
@@ -701,7 +701,7 @@ def start_test(ctx, subtests, rqueue):
# test results are queued and printed at the very end so its
# difficult to know *where* a test failed (python gives a stack
# trace but printing the exception/failure immediately shows
- # where in the debug logs something failed). Moreso if there are
+ # where in the debug logs something failed). More so if there are
# several test functions inside a single python file they run
# as a single test and it is difficult (again) to know where
# something failed.
@@ -731,7 +731,7 @@ def start_test(ctx, subtests, rqueue):
func, file = str(t).split(' ')
#
# TODO: There may be a better way of doing this
- # but strigifying the test class gives us a string:
+ # but stringifying the test class gives us a string:
# <function> (<file>.<class>)
#
file = file.strip('()').split('.')[0] + '.py'
@@ -981,7 +981,7 @@ def run_auto_tests(ctx, args):
p = multiprocessing.Process(target=start_test, args=(ctx, subtests, rqueue))
p.start()
# Rather than time each subtest we just time the total but
- # mutiply the default time by the number of tests being run.
+ # multiply the default time by the number of tests being run.
p.join(int(args.timeout) * len(subtests))
if p.is_alive():
@@ -133,7 +133,7 @@ class Process(subprocess.Popen):
f.write(stamp + ': ')
# Write out a separator so multiple process calls per
- # test are easer to read.
+ # test are easier to read.
if instance.hup:
f.write("Terminated: {}\n\n".format(instance.args))
@@ -51,7 +51,7 @@ static void cmac_test(const void *data)
for (i = 0; i < test->tag_len; i++)
sprintf(tag_str + (i * 2), "%02x", test->tag[i]);
- printf("Tag = %s (%zu octects)\n", tag_str, test->tag_len);
+ printf("Tag = %s (%zu octets)\n", tag_str, test->tag_len);
result = cmac_aes(test->key, test->key_len,
test->msg, test->msg_len, tag, test->tag_len);
@@ -50,7 +50,7 @@ static void hmac_test(const void *data)
hmac_len = strlen(test->hmac) / 2;
- printf("HMAC = %s (%d octects)\n", test->hmac, hmac_len);
+ printf("HMAC = %s (%d octets)\n", test->hmac, hmac_len);
result = hmac_md5(test->key, test->key_len,
test->data, test->data_len, output, hmac_len);
@@ -50,7 +50,7 @@ static void hmac_test(const void *data)
hmac_len = strlen(test->hmac) / 2;
- printf("HMAC = %s (%d octects)\n", test->hmac, hmac_len);
+ printf("HMAC = %s (%d octets)\n", test->hmac, hmac_len);
result = hmac_sha1(test->key, test->key_len,
test->data, test->data_len, output, hmac_len);
@@ -50,7 +50,7 @@ static void hmac_test(const void *data)
hmac_len = strlen(test->hmac) / 2;
- printf("HMAC = %s (%d octects)\n", test->hmac, hmac_len);
+ printf("HMAC = %s (%d octets)\n", test->hmac, hmac_len);
result = hmac_sha256(test->key, test->key_len,
test->data, test->data_len, output, hmac_len);
@@ -52,7 +52,7 @@ static void kdf_test(const void *data)
kdf_len = strlen(test->kdf) / 2;
- printf("PRF = %s (%d octects)\n", test->kdf, kdf_len);
+ printf("PRF = %s (%d octets)\n", test->kdf, kdf_len);
result = kdf_sha256(test->key, test->key_len, test->prefix,
test->prefix_len, test->data, test->data_len,
@@ -52,7 +52,7 @@ static void prf_test(const void *data)
prf_len = strlen(test->prf) / 2;
- printf("PRF = %s (%d octects)\n", test->prf, prf_len);
+ printf("PRF = %s (%d octets)\n", test->prf, prf_len);
result = prf_sha1(test->key, test->key_len, test->prefix,
test->prefix_len, test->data, test->data_len,