diff mbox series

[v2] handshake: add more debugging around PMKSA caching

Message ID 20250106153430.132452-1-prestwoj@gmail.com (mailing list archive)
State Accepted, archived
Headers show
Series [v2] handshake: add more debugging around PMKSA caching | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
prestwoj/iwd-alpine-ci-fetch success Fetch PR
prestwoj/iwd-ci-gitlint success GitLint
prestwoj/iwd-ci-fetch success Fetch PR
prestwoj/iwd-alpine-ci-setupell success Prep - Setup ELL
prestwoj/iwd-ci-setupell success Prep - Setup ELL
prestwoj/iwd-ci-incremental_build success Incremental build not run PASS
prestwoj/iwd-alpine-ci-makedistcheck success Make Distcheck
prestwoj/iwd-alpine-ci-incremental_build success Incremental build not run PASS
prestwoj/iwd-ci-build success Build - Configure
prestwoj/iwd-alpine-ci-build success Build - Configure
prestwoj/iwd-ci-clang success clang PASS
prestwoj/iwd-ci-makecheckvalgrind success Make Check w/Valgrind
prestwoj/iwd-ci-makecheck success Make Check
prestwoj/iwd-alpine-ci-makecheckvalgrind success Make Check w/Valgrind
prestwoj/iwd-alpine-ci-makecheck success Make Check
prestwoj/iwd-ci-makedistcheck success Make Distcheck
prestwoj/iwd-ci-testrunner success test-runner PASS

Commit Message

James Prestwood Jan. 6, 2025, 3:34 p.m. UTC 
Instead of just printing the PMKSA pointer separate this into two
separate debug messages, one for if the PMKSA exists and the other
if it does not. In addition print out the MAC of the AP so we have
a reference of which PMKSA this is.
---
 src/handshake.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Denis Kenzior Jan. 6, 2025, 3:39 p.m. UTC | #1 
Hi James,

On 1/6/25 9:34 AM, James Prestwood wrote:
> Instead of just printing the PMKSA pointer separate this into two
> separate debug messages, one for if the PMKSA exists and the other
> if it does not. In addition print out the MAC of the AP so we have
> a reference of which PMKSA this is.
> ---
>   src/handshake.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)

Applied, thanks.

Regards,
-Denis
diff mbox series

Patch

diff --git a/src/handshake.c b/src/handshake.c
index f73f91d1..bee31beb 100644
--- a/src/handshake.c
+++ b/src/handshake.c
@@ -1272,10 +1272,12 @@  void handshake_state_cache_pmksa(struct handshake_state *s)
 {
 	struct pmksa *pmksa = handshake_state_steal_pmksa(s);
 
-	l_debug("%p", pmksa);
-
-	if (!pmksa)
+	if (!pmksa) {
+		l_debug("No PMKSA for "MAC, MAC_STR(s->aa));
 		return;
+	}
+
+	l_debug("Caching PMKSA for "MAC, MAC_STR(s->aa));
 
 	if (L_WARN_ON(pmksa_cache_put(pmksa) < 0))
 		l_free(pmksa);