[RFC,0/4] Replace terraform update_ssh_config module

Message

Chuck Lever Jan. 31, 2025, 8:19 p.m. UTC

From: Chuck Lever <[e-mail]>

*** Request For Comment ***

Luis suggested merging the way guestfs and terraform handle ssh
host config. Luis, please let me know if I've grossly misunderstood
your suggestion.

Vagrant is deprecated, so it will not be modified by these changes.
The two remaining virtualization mechanisms have the same underlying
purpose:

 - Set up ssh to enable Ansible to have passwordless access to
   the target nodes

 - Make human ssh to the target nodes as painless as possible

But they have grown apart in implementation over the years. This
series is an attempt to build shared infrastructure that can be
triggered by the common "bringup" and "destroy" make targets.

Eventually IMO the SSH Kconfig options for terraform need to be
merged with the options from kconfigs/Kconfig.ssh. This series does
not attempt to do that yet.

Daniel had some thoughts about how combined infrastructure might
work which I haven't integrated here as the discussion doesn't
seem finished yet.

I have tested this series with guestfs and AWS. I have provisioned
an Azure account, and a colleague of mine has an active OCI account.
These should help with finalizing and testing the needed non-AWS
terraform changes, which are not yet part of this series.

Chuck Lever (4):
  guestfs: Rename the update_ssh_config_guestfs role
  update_ssh_config: Add always-run ssh clean-up steps
  terraform: Add ssh hosts to ~/.ssh/config_kdevops_{{ sha1sum }}
  terraform: Remove the terrraform update_ssh_config module

 Makefile                                      |   1 +
 playbooks/add_ssh_hosts_terraform.yml         |   5 +
 .../add_ssh_hosts_terraform/defaults/main.yml |   2 +
 .../add_ssh_hosts_terraform/tasks/main.yml    |  57 +++++++
 .../templates/ssh_config.j2                   |  15 ++
 .../roles/update_ssh_config/tasks/main.yml    | 150 ++++++++++++++++++
 .../update_ssh_config_guestfs/tasks/main.yml  |  71 ---------
 playbooks/update_ssh_config.yml               |   5 +
 playbooks/update_ssh_config_guestfs.yml       |   4 -
 scripts/bringup.Makefile                      |   7 +
 scripts/destroy_guestfs.sh                    |   6 -
 scripts/guestfs.Makefile                      |   6 -
 scripts/ssh.Makefile                          |  13 ++
 scripts/terraform.Makefile                    |   6 +-
 terraform/aws/output.tf                       |  30 +---
 terraform/aws/update_ssh_config.tf            |   1 -
 terraform/azure/update_ssh_config.tf          |   1 -
 terraform/gce/update_ssh_config.tf            |   1 -
 terraform/oci/update_ssh_config.tf            |   1 -
 terraform/openstack/update_ssh_config.tf      |   1 -
 terraform/update_ssh_config.tf                |  17 --
 21 files changed, 266 insertions(+), 134 deletions(-)
 create mode 100644 playbooks/add_ssh_hosts_terraform.yml
 create mode 100644 playbooks/roles/add_ssh_hosts_terraform/defaults/main.yml
 create mode 100644 playbooks/roles/add_ssh_hosts_terraform/tasks/main.yml
 create mode 100644 playbooks/roles/add_ssh_hosts_terraform/templates/ssh_config.j2
 create mode 100644 playbooks/roles/update_ssh_config/tasks/main.yml
 delete mode 100644 playbooks/roles/update_ssh_config_guestfs/tasks/main.yml
 create mode 100644 playbooks/update_ssh_config.yml
 delete mode 100644 playbooks/update_ssh_config_guestfs.yml
 delete mode 120000 terraform/aws/update_ssh_config.tf
 delete mode 120000 terraform/azure/update_ssh_config.tf
 delete mode 120000 terraform/gce/update_ssh_config.tf
 delete mode 120000 terraform/oci/update_ssh_config.tf
 delete mode 120000 terraform/openstack/update_ssh_config.tf
 delete mode 100644 terraform/update_ssh_config.tf