From patchwork Sun Mar 23 11:50:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 14026486 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44E6E1EE03C for ; Sun, 23 Mar 2025 11:50:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742730611; cv=none; b=VWzc1KdWrEgEx74uBnVMPMXNzuqvKaHl8kl5T0yD/NLsOfKDkbiSgODu8QUkxO8M+j0Y1kowUg4pvxzJuMKY5uUveYMPeQZc4SvtRrEALP7E/Y7A5CwjIzPcbGKGkPTE/iBDRAZjYPVFaeO82ESeHPMkGCLjhprfbUmEQKU/JxE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742730611; c=relaxed/simple; bh=UzCkNI/7Uzot2MYpGjHMATcLD2T6J8DiEcuu7y1kQq8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hGoG/tEao7rVVslnjMC0DGdEqozQ14wzucGQ/EZcZA1FzJlSwPT95Ss9Lc5Tlq+K0QAYGlRTgKC65wKSrgNb7mMupm9Vx7umSjJdFgIfkyx8L+V9MHicwhrUIhiLvCHAuUZTVcJjbRQpjLVNEKAZs/NOtqf/c/ifaRjmAPNiq1M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=o+NtSnZX; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="o+NtSnZX" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=G5FHSsdSzsNqaSSHacPWi5m/KODBv/n5LNq/imthkd4=; b=o+NtSnZXXCe1t5Z5hzTdPDlEvz L/ycIWgUMNcUgzHc/c0HXMSAlS5/rBh+tpf/wypyWkaVchQaF+dSek46nMOUzBAZsA7y0BGZ4VIVX mPxp501IZ2T0Ga8D1SA6WaBW8bqx2mVQZnIstouYAV7BjOXhjbYhd/v6BB5ciX24iZoplpLwoCbue xW1Z3VxQMkc/3HHboJUvlYgLdhqeur8+cGYMi6pFGlxRFkeaQ2yrmgTMqRaXIvY7JXJqhT4pgOxLA s6SnCYRna05qTOdSsSapkO6E39ziOMxg9nCC1FoqtxbNUeNh5ZhNnqdOvdBv5q28NGMvTA7tg0bu8 hkjpVl/g==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1twJqD-0000000181k-3gXv; Sun, 23 Mar 2025 11:50:09 +0000 From: Luis Chamberlain To: kdevops@lists.linux.dev Cc: Luis Chamberlain Subject: [PATCH 0/6] debian / libvirt / devconfig fixes Date: Sun, 23 Mar 2025 04:50:03 -0700 Message-ID: <20250323115009.269172-1-mcgrof@kernel.org> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Sender: Luis Chamberlain Here are a few enhancements to debian guests so to ensure we remove the unattended-upgrades package from the start so to prevent tons of silly issues it can create. The next set of changes are related to the confusing way in which we define the kdevops storage pool path in one way in kconfig but use it differently in yaml / ansible. This then phases out a few commands from shell into ansible and adds sanity checks back, this shows how using ansible can be more precise. Lastly, there's one generic fix for devconfig so we ensure we don't use dashes on the kdevops host prefix. Luis Chamberlain (6): scripts/bringup_guestfs.sh: uninstall unattended-upgrades on debian guests devconfig: ensure unattended-upgrades is not installed on debian libvirt: use consistent pool path variables and use optional yaml output Kconfig: adopt output yaml for KDEVOPS_FIRST_RUN guestfs: add ansible group permisison check on libvirt system uri gen_nodes: ensure kdevops prefix has no dashes Kconfig | 1 + kconfigs/Kconfig.guestfs | 15 +++++ kconfigs/Kconfig.libvirt | 11 +++- .../roles/bringup_guestfs/tasks/main.yml | 59 +++++++++++++++++++ .../tasks/install-deps/debian/main.yml | 22 +++++++ playbooks/roles/gen_nodes/tasks/main.yml | 5 ++ scripts/bringup_guestfs.sh | 6 +- scripts/bringup_vagrant.sh | 2 +- scripts/destroy_guestfs.sh | 2 +- scripts/destroy_vagrant.sh | 2 +- scripts/gen-nodes.Makefile | 6 -- scripts/guestfs.Makefile | 9 +-- scripts/prune_stale_vagrant.sh | 2 +- scripts/vagrant.Makefile | 5 -- 14 files changed, 120 insertions(+), 27 deletions(-)