From patchwork Tue Oct 15 11:34:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Gomez via B4 Relay X-Patchwork-Id: 13836229 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8BB81E490B for ; Tue, 15 Oct 2024 11:35:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728992110; cv=none; b=XySvHx+7yWiU1NClGZLnypw0G+l7b14YVY7uqx6ZkoI6SptdL/N1rXIjy51gxODoOOs54CnGjeD8lV3+dE7Zne9K+IOtRAOaPwhbQpwa+zCasYYzhffePLNauzMVqQ3siBe+xVe/dFItTFmbRwQl6cNHcnDhq9lUdoeS0iwkOZY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728992110; c=relaxed/simple; bh=U4UFcuHjeCeWQ2aPGHF2h8ju+lOHIcKPxednDLW90Ks=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fhZa1tVeJurOgTsqwjumconm0hBEb5jI7i1jCzSI4avty9B76zm2OyXd5PRGKaSA2ik9eAsqytjimiw7GB2rWvFzjZpixx0qCc2zivt8+/bgFVYgr4hX+Nlnyw7vc1Kvv6aglNH9pfVT1fAWOFFBpZmt/9LKqsR8ImIFwenYaBY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nHdNaWXc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nHdNaWXc" Received: by smtp.kernel.org (Postfix) with ESMTPS id 87D13C4CEC6; Tue, 15 Oct 2024 11:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728992110; bh=U4UFcuHjeCeWQ2aPGHF2h8ju+lOHIcKPxednDLW90Ks=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=nHdNaWXcyl0wlkzpcwVVVaUOMXWFPpUufQolfyhYDCqDpg3QaRfFyFtvSr9wtU1k0 yXoBc7oawFk72eHndrnd/LMq4ul2iVOJq4KZm+x+TztNhd8SX99bSmdyvGVIqbMM3Z gaubWuJlnfbDKnvjfE2SfWXxAQbxpFzlq0lkFeprHaygoNQsQ7kFbEn/Qcy5vvWPL3 KJouRhIMtHHQT3t+8MMSCFUDloGjMzj8i3toCBPlEvIAXjl9zOyzioZULfSV1UFcLh a6b4Z6ounsmfN+j/7ponM8YEbr3CZxy3Mpu2Vucd2jfJrIlN++B9n1KdyYHOTygj86 4t74jyBjUrSnA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77812CFC291; Tue, 15 Oct 2024 11:35:10 +0000 (UTC) From: Daniel Gomez via B4 Relay Date: Tue, 15 Oct 2024 13:34:51 +0200 Subject: [PATCH 1/5] scripts: lib: rename KDEVOPS_WORKFLOW_FSTESTS Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241015-bringup-guestfs-debug-v1-1-bd74c0c31412@samsung.com> References: <20241015-bringup-guestfs-debug-v1-0-bd74c0c31412@samsung.com> In-Reply-To: <20241015-bringup-guestfs-debug-v1-0-bd74c0c31412@samsung.com> To: kdevops@lists.linux.dev, Luis Chamberlain Cc: "Daniel Gomez (Samsung)" , Daniel Gomez X-Mailer: b4 0.15-dev-2a633 X-Developer-Signature: v=1; a=ed25519-sha256; t=1728992109; l=976; i=da.gomez@samsung.com; s=20240621; h=from:subject:message-id; bh=agitDxiFrlhGQt6+adPfPU5KDudXEO2FENVxQ7uzWr8=; b=Q8aKuK61rd1dzqJEEStXfu7NcfeQvfWKTqzgYFF/CDZHRrLKFSScrxAcf5Id77bo9GnniWNNt nnL7ZWpV6DOB+AHwZ4g3nO8dXPzpi0+0WvydSLVdzve+EnrSoPUowDH X-Developer-Key: i=da.gomez@samsung.com; a=ed25519; pk=BqYk31UHkmv0WZShES6pIZcdmPPGay5LbzifAdZ2Ia4= X-Endpoint-Received: by B4 Relay for da.gomez@samsung.com/20240621 with auth_id=175 X-Original-From: Daniel Gomez Reply-To: da.gomez@samsung.com From: Daniel Gomez kdevops variable was renamed and this was silently failing. Make sure the proper workflow variable is checked but only if defined/set to avoid 'unbound variable' issue. Signed-off-by: Daniel Gomez --- scripts/lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/lib.sh b/scripts/lib.sh index 041b7e279a0f9793bcb5ee797caa244ceeccdd01..56093b1a58ea1af104d9c0af2842b105783dbe80 100644 --- a/scripts/lib.sh +++ b/scripts/lib.sh @@ -33,7 +33,7 @@ FSTESTS_STARTED_FILE="${TOPDIR}/workflows/fstests/.begin" BLKTESTS_STARTED_FILE="${TOPDIR}/workflows/blktests/.begin" REBOOT_LIMIT_STARTED_FILE="${TOPDIR}/workflows/demos/reboot-limit/.begin" -if [[ "$CONFIG_KDEVOPS_WORKFLOW_FSTESTS" == "y" ]]; then +if [[ "${CONFIG_KDEVOPS_WORKFLOW_ENABLE_FSTESTS+x}" && "$CONFIG_KDEVOPS_WORKFLOW_ENABLE_FSTESTS" == "y" ]]; then FSTYP="$CONFIG_FSTESTS_FSTYP" TEST_DEV="$CONFIG_FSTESTS_TEST_DEV" fi