From patchwork Wed Dec 18 10:30:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13913372 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE2511F2C4C for ; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517812; cv=none; b=IEp9oTeYjiNetf/JGGmQvy+ageEFr5UlBsBOm2wQ5A2uu4QknNwkmjj8hjtOe3LsmO4VCh1CK83kgerO+VJGJIIoMVXXZZ/fhN6AhqsY1HtMC4kJ4W/heY9oaUhL5aIoUEmoZD9FKeia2ndMS7gjk3dAYkQdC0lF0Zu3BhSYz0A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734517812; c=relaxed/simple; bh=uLN69fmmg4NNyq1bXPCNbwQrJjnLrTzRZWnbyJaeuXI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gNPAQthuAnQiAyQzK/1MS8WWdtmtdD2m5CvkXa0ABKhkvdCAculawPsDbY0oiu0thBU2VPsBEyI+ve5J3SjbZLg3NcnxkBKzlo5jiB4Rj2aOzkXUtbInquRj4mMWsqmObOYQSZjlCuLCUjrXbWisizM3sXDdd/ngezi3Dpn/Wx4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k/jC4ri3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k/jC4ri3" Received: by smtp.kernel.org (Postfix) with ESMTPS id 8B147C4CEEB; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734517812; bh=uLN69fmmg4NNyq1bXPCNbwQrJjnLrTzRZWnbyJaeuXI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=k/jC4ri35eGt5siacx1tfPl5RFd+2Lnr5eKYrZ59m2mFH3864wn9vNjjGKaLUshFk LTPPpfW6BLn9pE6Lb85bOXIdMSZwLcmDnbeW1xuDtmgglySBcry1/4TprR8A5eZFDf DZ48Thq/7tyLadB0LXgtB+h4mc5hPvU7v5FuwbiZlWdgCWCXwrqzC0Lfvtv66Xgk1B 8MT2A/XmfZnzL+MtKykMyH0/HfFZf/NhEGbX/sMIOOyQZIjWualtFeMzQw+DgiLY5P f8+EZ33ZuKRRPTwkkM3hPC79LMyzCUkmWt0tCO4s0DrJiMmhKzPYEE7c3ZOse+ML02 PBa8FwgND5EQA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84D27E77187; Wed, 18 Dec 2024 10:30:12 +0000 (UTC) From: Joel Granados Date: Wed, 18 Dec 2024 11:30:03 +0100 Subject: [PATCH 09/12] ansible: Reduce long ansible messages for readability Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241218-jag-bringup_fixes-v1-9-0bf2e07c640c@kernel.org> References: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> In-Reply-To: <20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=2148; i=joel.granados@kernel.org; h=from:subject:message-id; bh=uLN69fmmg4NNyq1bXPCNbwQrJjnLrTzRZWnbyJaeuXI=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGdipDCeCuMToaZXCrHAMoZ3iDZ/n9RrydmVq YRo5MDHjS8oJ4kBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnYqQwAAoJELqXzVK3 lkFPnDYMAIB4hVQFCkHQoCFUSdP8aajmUUSgf78c023y7z0//ISY2ehdY8lAYTAiNzxxRUx1t1a RTfEMK9A0egAgxFb8NnU9ZGNVzIaVrNnE0J0rt5R6g3c8BhF/808dzFeEJjdqRUj71dBdFZnZE6 BQdGf5wQPCyTesRjuCMPxzJ+9mhhQ/ZH8ralHg4pAc2Py2enYnXAzpcoBgESTSNtfr6h8TZ1QrF Bod5NEg5nuIjdvBVO/FcyIDxP5X0BoeLkXglM/93y7qWtBzFj5sGAr3Bdirl+5m5Hib0HAu0PAM BQcWOgdcrCr4gNsI9WQM0wJzIalKShnjmnk3gup1MUGhQSzrIaFVw4JayT9I0RHNK9aOQK8ghtj hmAC2+dWmSkTeTy8+jaEHpELEfcimljM/uZZPh80+9FGhvuZFZ0SIgrzan/1AdRWYBvhNCAW9xx OJZKjaunOSPcMPQ1iuQVTbN0s3AJxFELloxVrynCeWjfCCOfsXy6NmPybq4Lpdf+MoZXXVpFT64 0k= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 Signed-off-by: Joel Granados --- playbooks/roles/bringup_guestfs/tasks/main.yml | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/playbooks/roles/bringup_guestfs/tasks/main.yml b/playbooks/roles/bringup_guestfs/tasks/main.yml index c764ae4..fbbb378 100644 --- a/playbooks/roles/bringup_guestfs/tasks/main.yml +++ b/playbooks/roles/bringup_guestfs/tasks/main.yml @@ -6,7 +6,7 @@ - name: Fail if {{ topdir_path }}/.config is not present fail: - msg: "You have not configured kdevops yet, configure kdevops first." + msg: "kdevops is not confgured. You must run 'make menuconfig'" when: not config_file.stat.exists or not config_file.stat.isreg tags: [ 'config-check' ] @@ -63,7 +63,10 @@ - name: Fail if dnsmasq configuration files exist fail: - msg: "dnsmasq configuration files or directories still exist. Please remove the following to fully uninstall dnsmasq:\n{{ dnsmasq_config_files | join('\n') }}" + msg: | + dnsmasq configuration files or directories still exist. + Please remove the following to fully uninstall + dnsmasq:\n{{ dnsmasq_config_files | join('\n') }} when: - distro_debian_based|bool - dnsmasq_config_files.results | selectattr('stat.exists') | list | length > 0 @@ -95,7 +98,12 @@ - name: Fail if dnsmasq service is enabled or active fail: - msg: "dnsmasq service is {{ 'enabled' if dnsmasq_enabled.rc == 0 else 'active' if dnsmasq_active.rc == 0 else 'present' }}. Please ensure dnsmasq is fully uninstalled and disabled. Run 'sudo systemctl disable dnsmasq' and 'sudo systemctl stop dnsmasq' to disable and stop the service." + msg: | + dnsmasq service is + {{ 'enabled' if dnsmasq_enabled.rc == 0 else 'active' if dnsmasq_active.rc == 0 else 'present' }}. + Please ensure dnsmasq is fully uninstalled and disabled. + Run 'sudo systemctl disable dnsmasq' and 'sudo systemctl + stop dnsmasq' to disable and stop the service. when: - distro_debian_based|bool - dnsmasq_config_files | length > 0