From patchwork Mon Jan 13 11:52:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Granados X-Patchwork-Id: 13937225 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E89BC1CAA9D for ; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; cv=none; b=YqIO6hZtq0x1PDcryCW0y2i+GK+1tS65DAQIoP8BqZpChAKrYQBY6beTufN5d7a8BOxx06SOA1rsLtOUbEbqLxiXKlCQa89LBHpSIYwX9QCe0XeGjWa+4CbNKwm97xTPSTZul+9EbpU7lpHHYP+Pi13MblkKadt6e2jtE82V1Yc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736769196; c=relaxed/simple; bh=bGbxHk/oOI1UiN1TNn3H56GZV7Xir+xzbDLx5Xo3kUg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IMfYzBbIkbMsCkR6Rl2Qe2i/GQrPtRo0PqYbhTEdckD24nDPC/ihlLQNMiybX+OwhoEPLPotOcYnE8unQxMz/70gGp71gmHqHbmScrq1Om8KFKlKK4PO3fBQ3rCr7SmyKRJStQBjXryThPp2fp4/rtjxl04G1wuT2/aQRw3d+k4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Rt8LRt4p; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Rt8LRt4p" Received: by smtp.kernel.org (Postfix) with ESMTPS id 83F4CC4CEE2; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736769195; bh=bGbxHk/oOI1UiN1TNn3H56GZV7Xir+xzbDLx5Xo3kUg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Rt8LRt4pVcbiUCow8AAbz3t+2DPi33KupPqhlXh5WTvs+nleBSMtT9o8gvSfccNLH PhLWhkE3wNU34sxb5l653yyM5mR8zWLdTXk8Az22gbqOq9SNyx8IHgS8OPtdVXTCKJ M4a4z9hiqmBERoP/VVBn4lCMcohQJUmLpDLkRfG+OXbYV7qAStMqSRAVyjMxi4tNdZ ZjjXjdJY1SVst+gzX/ndPu5Or7VC+3IJZuXowSR5MxaKRbrQAkD8qVdzMZdBx2iqs3 HVPhkIjVJ95HixWsenDVuVXBWgqliolIOmceGnU8B6n2GWPcZ0ynnVhS60QEAEhffF e2F6EwJMYORrg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AEB5C02180; Mon, 13 Jan 2025 11:53:15 +0000 (UTC) From: Joel Granados Date: Mon, 13 Jan 2025 12:52:59 +0100 Subject: [PATCH RESEND 01/12] Kconfig: Add error path in conf_value_to_yaml Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250113-jag-bringup_fixes-v1-1-fb28030b1f26@kernel.org> References: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> In-Reply-To: <20250113-jag-bringup_fixes-v1-0-fb28030b1f26@kernel.org> To: kdevops@lists.linux.dev Cc: Joel Granados , mcgrof@kernel.org, da.gomez@samsung.com X-Mailer: b4 0.15-dev-00a43 X-Developer-Signature: v=1; a=openpgp-sha256; l=1224; i=joel.granados@kernel.org; h=from:subject:message-id; bh=bGbxHk/oOI1UiN1TNn3H56GZV7Xir+xzbDLx5Xo3kUg=; b=owJ4nAHtARL+kA0DAAoBupfNUreWQU8ByyZiAGeE/qLccEOdp+Z9kH3Kj7HRdarmGvBKO+beK zqz4GVYI29D+IkBswQAAQoAHRYhBK5HCVcl5jElzssnkLqXzVK3lkFPBQJnhP6iAAoJELqXzVK3 lkFPGaIL/RJEVIvcivcFaEOzQc9S4M1OxImLWFEDCAt1L7Y/htMmnTYrZQZe9RDOCbecOKpTRS3 4u2ELGIdMxWOrSoRY0Gm2QiMdziOpsGG2pkk8idx3/7CvnDERA62wpARPUpyxSsBL9Z/+kj9kC5 xL4qepsGc0PjDZjViWPEW3v7gc1kTKUwnlZeIpMhrW3+zJvqNrBAKR0LnvJ3JaRb4DTfXzSzi0H /hCOb0ebMD6JNkqNu4A96M+zuTv+hk0rvnnXwOpJ9oOyb5t0ZgFKN7JfHvv73r9RLOaiRgQQYxu 48aZtvJfKwTJ8uMVWKwzGoOEp5LP8SvQdCJQ83p4KaacaRrQYtuXhz57SOrTyWutyS6EUK0XSfQ hIvGzW4Ujo7dhYTfq4srYdj6kAiRoNbxMvRjSQkwvskdCB/Rweu1WFdUPvaL6u4qex4gzj4nZr0 G9wRZizU69l8338RGrAydZydtb1X9extqD0uG5WCT3e6dBFEzDagqZfFT7rOfkYUsA7LMOQQeA7 4k= X-Developer-Key: i=joel.granados@kernel.org; a=openpgp; fpr=F1F8E46D30F0F6C4A45FF4465895FAAC338C6E77 X-Endpoint-Received: by B4 Relay for joel.granados@kernel.org/default with auth_id=239 The asprintf call returns -1 on error. In this case the value of yaml_value is undefined. Return NULL, so the caller can handle the error. Signed-off-by: Joel Granados Reviewed-by: Luis Chamberlain --- scripts/kconfig/confdata.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c index 0156b38..49a5729 100644 --- a/scripts/kconfig/confdata.c +++ b/scripts/kconfig/confdata.c @@ -669,14 +669,14 @@ static char *conf_value_to_yaml(struct symbol *sym, const char *val) yaml_value = strdup(val); break; case S_HEX: - asprintf(&yaml_value, "0x%s", val); - break; - case S_STRING: - /* Wrap strings in quotes */ - asprintf(&yaml_value, "\"%s\"", val); - break; - case S_BOOLEAN: - case S_TRISTATE: + if (asprintf(&yaml_value, "0x%s", val) < 0) + return NULL; + case S_STRING: + /* Wrap strings in quotes */ + if (asprintf(&yaml_value, "\"%s\"", val) < 0) + return NULL; + case S_BOOLEAN: + case S_TRISTATE: if (strcmp(val, "y") == 0) yaml_value = strdup("True"); else if (strcmp(val, "n") == 0)