From patchwork Tue Jan 28 17:32:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 13952825 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECEFF1DE4C8 for ; Tue, 28 Jan 2025 17:32:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738085557; cv=none; b=BDnwIOq3dY3NkxIbqyBFlz2pB46Qiz6TaxUD/FxucaG6OYUpBzKkfrAxBA1T3kM+NEG/fZrBIIFfOhDymUYewemxaepm2yjW+puuaLtEKal4UDISS0FOky9IzDGcMv50AJZzvm5wktuxh8K69Ufo8DaaAHKxJ0It9Cs3MZ3wxjU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738085557; c=relaxed/simple; bh=TDCTWvOMinFxRD/zTcYjWRCnzAlyNTuhwm5DG0JZZI0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=F1etXD+vOSKn1MzjFkd4oKRnDhsYqMexRYK2UQ1dohJYsExye7mbHYtj519wMrtDS88k51Dy83+/pPxjtg5WFFMn1OTbC35dgQySGzTmpzJPIyyIWjIUEeUuzoscdlPTGyD/FCcoIZsZcFGaXldlZ8+u+RBAP5jVqK0//ZmIEog= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gPqhdwZD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gPqhdwZD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE828C4CED3; Tue, 28 Jan 2025 17:32:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738085556; bh=TDCTWvOMinFxRD/zTcYjWRCnzAlyNTuhwm5DG0JZZI0=; h=From:To:Cc:Subject:Date:From; b=gPqhdwZDzw+myIGNJSHfYPBKeq9nYNPJpCqV/3/Nb4MOOmt8OFF+fzCjxxRH+NLzo tAUDIZTgNQlbPG4Lm2JPoeJlZ5TT3wFhL5k4Y7YmGap3jPVvjJYthbgS4MRwxnnakb zsnsSxiOPScMT1vIw++3aYxSDIAHPuRlRD2P33LP7uITlbqFo/wpzB1ZQepVRIRQwS H6Dy0MrAuX3lWgBxYYrpfRVpdQoOggjBqYm3XUDF4NMahKXnRX5kqNvzEvK59Nixv/ opSIUm8i2NXkOHOYT7vwOyQmJNklbgCItKxm+MiMVKbQJd1gN6g4oV1OeLwznnuk4Z xapAHA90ehAow== From: cel@kernel.org To: da.gomez@samsung.com Cc: , Chuck Lever , Joel Granados Subject: [RFC PATCH] devconfig: install-deps is skipped in some configurations Date: Tue, 28 Jan 2025 12:32:33 -0500 Message-ID: <20250128173233.1084701-1-cel@kernel.org> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Chuck Lever A recent commit replaced import_tasks with include_tasks in a few steps in the devconfig playbook. The Ansible "import_tasks" documentation says: > Tags are not interpreted for this action, they are applied to the > imported tasks Revert some of the import_tasks conversions to ensure those steps are run according to the command-line tag settings. For the original problem that I tripped on, add tags to ensure those sub-steps get run as needed. Reported-by: Joel Granados Closes: https://lore.kernel.org/kdevops/20250128112453.rawxqvpffxwupvco@AALNPWDAGOMEZ1.aal.scsc.local/T/#t Fixes: e1a41cd9d4ee ("devconfig: Replace import_tasks with include_tasks") Signed-off-by: Chuck Lever Reviewed-by: Daniel Gomez --- playbooks/roles/devconfig/tasks/main.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/playbooks/roles/devconfig/tasks/main.yml b/playbooks/roles/devconfig/tasks/main.yml index 51b890375215..84c5fa1f1cf8 100644 --- a/playbooks/roles/devconfig/tasks/main.yml +++ b/playbooks/roles/devconfig/tasks/main.yml @@ -32,9 +32,10 @@ # Distro specific - name: Install dependencies ansible.builtin.include_tasks: install-deps/main.yml + tags: ['vars', 'vars_simple'] - name: Configure custom repositories and install packages - ansible.builtin.include_tasks: config-custom-repos-and-packages/main.yml + ansible.builtin.import_tasks: config-custom-repos-and-packages/main.yml when: - ansible_facts['os_family']|lower == 'redhat' @@ -447,7 +448,7 @@ tags: [ 'console' ] - name: Update your boot GRUB file if necessary - ansible.builtin.include_tasks: update-grub/main.yml + ansible.builtin.import_tasks: update-grub/main.yml when: - grub2_config_file.stat.exists - devconfig_enable_console|bool @@ -637,7 +638,7 @@ tags: [ 'sysctl' ] - name: Rev the kernel to the latest distribution kotd - ansible.builtin.include_tasks: kotd-rev-kernel/main.yml + ansible.builtin.import_tasks: kotd-rev-kernel/main.yml when: - devconfig_enable_kotd|bool tags: [ 'kotd' ]