From patchwork Mon Mar 10 18:32:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 14010500 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 719852AD16 for ; Mon, 10 Mar 2025 18:32:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741631531; cv=none; b=W2PVKx/ZJOVNy65O0qmfZ0cKljGG+tiWPqdUd+144I8F8UAoFYeCXK2cBvO9E31drtfzIP285/sw2hRfKocV+vTBxpjd28K//GqenMTUUjtxHMejrP63eUfPc+NKmhJl8o9G59UJfh25jXbNGgHVXdgWTE9Gw/YIZ6OIcKQJ0Bg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741631531; c=relaxed/simple; bh=gqfS+grO/rGCBh5M2Pic+sWGeqxXnifQEX08yZbhbnc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gL6xxnipk7muoFHMBohRnPQsQ5FUPVzkMGnLov1UKyt0gIE3ak1guPWweis57Zx5yjanD/Z28J5bHtzUD+zXHZSYjAjxvuTEqfyFRgssVPbiYEAhFrxQw0s/CAa9FrMluQ5WFbuKltqfhMKZV3DJiuZ05HdV59/5L/Loqfvt7Q8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CKrSHbAM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CKrSHbAM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D32EC4CEEC; Mon, 10 Mar 2025 18:32:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741631530; bh=gqfS+grO/rGCBh5M2Pic+sWGeqxXnifQEX08yZbhbnc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CKrSHbAMLJ1Az+JNOpBrLjirNJ47pGYsITi8MMs8Cak4MWMWQu4wnb9wEqNS6hfXt /IC8ucPmlDrL8T6Uil5AjvTw9TXuu6M7gIhVcGFKbQE9KAiFSdD0Kr4znWFbk5q2s0 TduEmLmAUBnz/UtTvJ0i4TskviBNxbd61E9AKaY3Wr0H6gi+Soyp62AaEdVvfkFY0L hOpcnnCbOfOSJMEcWfuRXOu6rpcZ35sMELA6XSgzG+g5KjWB4CDEqnrMvgy/aGLnm4 gMtyTwIk5u8zbmmYA65fnTbP/SL8IUtSWtwuTQUGVmXxzOmYtX7gvToUbqy6ypQ6qC h/hLe0N3bgibQ== From: cel@kernel.org To: Cc: Chuck Lever Subject: [PATCH v1 1/4] linux-mirror: Fix installation on Fedora systems Date: Mon, 10 Mar 2025 14:32:05 -0400 Message-ID: <20250310183208.999430-2-cel@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250310183208.999430-1-cel@kernel.org> References: <20250310183208.999430-1-cel@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Chuck Lever I noticed that git-daemon was not installed when I set up the git mirror on my Fedora 40 control host. If "include_tasks:" has a tag, the included tasks also need to have a "tags:" attribute or they will not be run. Also, because my lab is already behind a firewall gateway, there happens to be no firewall running on my controller, so the "enable the git port" step fails with: firewall is not currently running, unable to perform immediate actions without a running firewall daemon Signed-off-by: Chuck Lever --- .../roles/linux-mirror/tasks/install-deps/fedora/main.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/playbooks/roles/linux-mirror/tasks/install-deps/fedora/main.yml b/playbooks/roles/linux-mirror/tasks/install-deps/fedora/main.yml index 2a93256a3d6e..01e98895cabe 100644 --- a/playbooks/roles/linux-mirror/tasks/install-deps/fedora/main.yml +++ b/playbooks/roles/linux-mirror/tasks/install-deps/fedora/main.yml @@ -9,6 +9,11 @@ state: present when: - install_linux_mirror|bool + tags: [ 'mirror' ] + +- name: Gather service facts + ansible.builtin.service_facts: + tags: [ 'mirror' ] - name: Open the firewall on control node for git traffic become: true @@ -22,3 +27,6 @@ state: enabled when: - install_linux_mirror|bool + - '"firewalld.service" in ansible_facts.services' + - ansible_facts.services['firewalld.service'].state == "enabled" + tags: [ 'mirror' ]