From patchwork Wed Mar 12 21:42:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Scott Mayhew X-Patchwork-Id: 14013946 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9464F1D5175 for ; Wed, 12 Mar 2025 21:43:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741815785; cv=none; b=bOFt4CUHW6uSXgwvZZR9DDJRNPaeZqgHIjfmAcqcPT8xQUa1g+znnyd6IMIlzXReMYJ6iBO5+waZ2Xw+Yr3QajNR7qLZyIb8Jo71PkiOO7/TQ4f7XhV9hICrBK2Rax0WoviUK5ZvHjH1PNBDbHT6fhBtIuRNtIytVstmur1dWlY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741815785; c=relaxed/simple; bh=D/QFywUijAYQd4e5cWsffOKIu8CsTzBsjTEtqJxKqhk=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:content-type; b=i07VvjZC4GisBfGfHJ22PbfnNHRy/mKn41dLttoyKYiAOvn3iRD8UyJEL+1b0SR10Hsv9fE7vae6VFL44Syx1ZNJ+Uww7FX+nveWyr7Br5exB/FAQtwtRtgMNSZDYlOstT/MwfB4tAhip5CTo9e472ZCAz7EiFJZKEdSPChCbwo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=a3o81CG1; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="a3o81CG1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741815781; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6p1Lo9RrzflfGo2W+9XJAzv7BNhC34bMAaOmlUCg2yg=; b=a3o81CG1/ZpYqmFJqyMwJks3OMOj/5T47iXEfHdSqY7qiwI33+3KD551seC/y3CVa5mTc5 fopwwAoen8h5Edd1ipzXy3D46yWiG3AkoPhbODCVEQ3WpREObKyPogHUMN2ERPWtIkdP/J Ikil1EHiWImIftEgGvN//Wtxeddzp20= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-KICMYtlrMj-CdrwkDjl1Kg-1; Wed, 12 Mar 2025 17:42:36 -0400 X-MC-Unique: KICMYtlrMj-CdrwkDjl1Kg-1 X-Mimecast-MFC-AGG-ID: KICMYtlrMj-CdrwkDjl1Kg_1741815756 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DFB471828A83 for ; Wed, 12 Mar 2025 21:42:35 +0000 (UTC) Received: from aion.redhat.com (unknown [10.22.80.106]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B7F2118001DE for ; Wed, 12 Mar 2025 21:42:35 +0000 (UTC) Received: from aion.redhat.com (localhost [IPv6:::1]) by aion.redhat.com (Postfix) with ESMTP id D066E338A12 for ; Wed, 12 Mar 2025 17:42:32 -0400 (EDT) From: Scott Mayhew To: kdevops@lists.linux.dev Subject: [PATCH v2 5/9] fstests: add makefile target to show test results Date: Wed, 12 Mar 2025 17:42:28 -0400 Message-ID: <20250312214232.955450-6-smayhew@redhat.com> In-Reply-To: <20250312214232.955450-1-smayhew@redhat.com> References: <20250312214232.955450-1-smayhew@redhat.com> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: CkYAL6mlqfazppHfCuqsSAx-uxIVJCM1K3ClWKR3Jv8_1741815756 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true Add 'fstests-show-results' makefile target to show test results. Under the hood, it more or less just does 'find ... | xargs cat'. By default, the xunit_result.txt file will be shown for the most recent kernel run. You can show the results for a different kernel by overriding the LAST_KERNEL variable, e.g. $ LAST_KERNEL=6.13.4-300.fc41.x86_64 make fstests-show-results You can change the files being shown by overriding the PATTERN variable. For example, to just see the xml output files: $ PATTERN="-name \"*.xml\"" make fstests-show-results or to see the xunit_results.txt and the bad results: $ PATTERN="\( -name xunit_results.txt -o -name \"*.bad\" \)" make fstests-show-results or you can do any combination thereof, e.g. $ LAST_KERNEL=6.13.4-300.fc41.x86_64 PATTERN="-name \"*.bad\"" make fstests-show-results Finally, note that if you override the PATTERN variable, then the output will also include the filename... otherwise it the output will not include the filename. The reason I did it this way for this workflow specifically is so that Luis can use 'make fstests-show-results' in his github workflow and he should get exactly the same output as he does today. Signed-off-by: Scott Mayhew Reviewed-by: Luis Chamberlain --- workflows/fstests/Makefile | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/workflows/fstests/Makefile b/workflows/fstests/Makefile index 344a1f8..40629fd 100644 --- a/workflows/fstests/Makefile +++ b/workflows/fstests/Makefile @@ -115,6 +115,28 @@ ifneq (,$(COUNT)) FSTESTS_DYNAMIC_RUNTIME_VARS += , "oscheck_extra_args": "-I $(COUNT)" endif +ifndef LAST_KERNEL +LAST_KERNEL := $(shell cat workflows/fstests/results/last-kernel.txt 2>/dev/null) +endif + +ifeq ($(LAST_KERNEL), $(shell cat workflows/fstests/results/last-kernel.txt 2>/dev/null)) +FIND_PATH := workflows/fstests/results/last-run +else +FIND_PATH := workflows/fstests/results/$(LAST_KERNEL) +endif + +ifndef PATTERN +PATTERN := -name xunit_results.txt +endif + +ifndef XARGS_ARGS +ifeq (-name xunit_results.txt,$(PATTERN)) +XARGS_ARGS := cat +else +XARGS_ARGS := -I {} bash -c 'echo "{}:"; cat {}; echo;' +endif +endif + fstests: $(FSTESTS_BASELINE_EXTRA) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -l localhost,baseline,dev \ -f 30 -i hosts playbooks/fstests.yml --skip-tags run_tests,copy_results $(LIMIT_HOSTS) @@ -218,6 +240,11 @@ fstests-dev-results: $(KDEVOPS_EXTRA_VARS) --extra-vars=@./extra_vars.yaml \ $(LIMIT_HOSTS) +fstests-show-results: + @find $(FIND_PATH) -type f $(PATTERN) \ + | xargs $(XARGS_ARGS) \ + | sed '$${/^$$/d;}' + fstests-help-menu: @echo "fstests options:" @echo "fstests - Git clones fstests, builds and install it"