From patchwork Sun Mar 23 11:50:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 14026487 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49D04202C53 for ; Sun, 23 Mar 2025 11:50:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742730611; cv=none; b=bFlJD5ZoueH94q1H0afltTSKcgjmgzeNHB567MOQ15edBpQ0dqTsKMWViu9aZ3+bfL+8yWBOdxVdHEqWd/y0bVf8EsG7cmJavPOlXJz1jACYW3LUvMaNtpmoo/gFUabR9YQbE8dUM1xhKX2UHKDFtygB1TkEmut4X88riWhEhJM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742730611; c=relaxed/simple; bh=DTMptcFU7ayKP5dNUTe/phyvBNsHAS8IUoEC29Oe0lM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Eu3uGmucNtC694/F+U/e3FAohgI0Tzr9wyD62IHIXk0zGaFBIpaUnJG/dguFrOyA1o4aaax5jJwYbOB2OSHHInQiWx/T8Y6dp+Yvtkj8NQn0q7pK6U+l7kTvOgfM4pGv0EVPx7AqOTwJ/tQB5sA8Vf5fXrfdq2TRsLtqiMWrZZ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=D+L6ZK0J; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="D+L6ZK0J" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=ciN0I8aTFtrlfHS74JZrGIkA6a2PuUD4BtCZ/Te0zok=; b=D+L6ZK0J8g8PmuhzrlcA6f522/ xXZOkRYZb6UjoHV7oQcUkHkET9XiM8gSR3D5RDZNYGzUFv+N6hZdWgj01b9I6GMRMPWLiT+772Rgt 432Sfjgcu0SbJO+FFvuMOY+mctDChZic7zvIvVZUWnkmXlXYdfKlfadvEOa13owGscQ12BCqmY6x2 RDDIPBPQQF1RE4MP4DLOnbdtbhppjgXwT/Mu27TsgewBAomdmBFqtKIKl03ipjS2WVyCK0XsujaS3 4iVbrxehRm9suqnnFPQu8Y28eRqNrJZ3Y50sTSgvN9r5fSHZM6Pgm0miqgaTrqSpFOvFdPAzLUxsS HW9HNANw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1twJqE-00000001828-0EAS; Sun, 23 Mar 2025 11:50:10 +0000 From: Luis Chamberlain To: kdevops@lists.linux.dev Cc: Luis Chamberlain Subject: [PATCH 6/6] gen_nodes: ensure kdevops prefix has no dashes Date: Sun, 23 Mar 2025 04:50:09 -0700 Message-ID: <20250323115009.269172-7-mcgrof@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250323115009.269172-1-mcgrof@kernel.org> References: <20250323115009.269172-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Sender: Luis Chamberlain Folks trying to use kdevops and testing with fstests will quickly find out a surprise that their config is not being parsed correctly until later. Fix this by preventing bringup if the prefix has a dash. We use the dash to help parallelize testing filesystem profiles and so the host prefix goes before the filesystem name and test profile. Signed-off-by: Luis Chamberlain --- playbooks/roles/gen_nodes/tasks/main.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/playbooks/roles/gen_nodes/tasks/main.yml b/playbooks/roles/gen_nodes/tasks/main.yml index d541dcbf1f54..8c6a1f705ee2 100644 --- a/playbooks/roles/gen_nodes/tasks/main.yml +++ b/playbooks/roles/gen_nodes/tasks/main.yml @@ -18,6 +18,11 @@ command: "id -g -n" register: my_group +- name: Fail if kdevops_host_prefix contains a dash + fail: + msg: "Invalid kdevops_host_prefix '{{ kdevops_host_prefix }}'. The prefix cannot contain a dash ('-')." + when: kdevops_host_prefix is search("-") + - name: Create guestfs directory ansible.builtin.file: path: "{{ guestfs_path }}"