From patchwork Sat Mar 29 23:01:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 14032810 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 043081ADC8D for ; Sat, 29 Mar 2025 23:01:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743289304; cv=none; b=l2PLArloHkM4a5cXho+qSGl80fVPmK62pAxb3GDItCHFPcT07HjDmiTvv8jh+mpnuuAPVTvrm1wxM17zOdeAtJAR5/BPJM8umfOhS2FVUA4+6nXzjdnsz+NgrGR7PMTbBoxNDYcINHrf5qP3mWu0+YeGQGkRd5J01Uc0j4m5qSQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743289304; c=relaxed/simple; bh=DTMptcFU7ayKP5dNUTe/phyvBNsHAS8IUoEC29Oe0lM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sAq8391+r6b5SpJpbVdpR9FhyXygzeEFUykZyBX4r1NGwu0lMbINiYc9yWXyiRHUDH+OlK6JdC1gHXpzhDtuR0NR5G26uT0GuUiBSx8GpM6ZjyBGNCk5NLYqKpjjVYXUy3t9PePonnMd4NT5BvAAwicaXf5MU0j4bF8pR9607UA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=pLv3K/vW; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="pLv3K/vW" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=ciN0I8aTFtrlfHS74JZrGIkA6a2PuUD4BtCZ/Te0zok=; b=pLv3K/vWkuEN+jd+kDpd2jks65 xW63omERy2Pz/n9vViiuNg196kMXd5oEqKz5FTGvVIWn03YkkTiumxNuAmLfrpUTa+Zgq5Grb828n EOw0J3juFtyqcplAeeUPjW6XoDkr21Yt1DcdG9IMq15JtaaFJchM9+BGgg2lDKo3xJ4JFKOnoLstt NU78LML33RVrB7yLauU0mTvFiXG8heBrJf+YIYUNfJr1gX+Hrm/o/WyBiQoyNX1hhbe2kxRlaolmB E0tmBhGQmdfLeVXQMY8GiBtCO9IlELf8RrnmIeppximpUzKd0+AfMRoBPYOoXMyYl18G4fmZ/Sx+B wXNhoB4g==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98.1 #2 (Red Hat Linux)) id 1tyfBO-0000000FbIg-29HO; Sat, 29 Mar 2025 23:01:42 +0000 From: Luis Chamberlain To: kdevops@lists.linux.dev Cc: Luis Chamberlain Subject: [PATCH 6/6] gen_nodes: ensure kdevops prefix has no dashes Date: Sat, 29 Mar 2025 16:01:41 -0700 Message-ID: <20250329230141.3718282-7-mcgrof@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250329230141.3718282-1-mcgrof@kernel.org> References: <20250329230141.3718282-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Sender: Luis Chamberlain Folks trying to use kdevops and testing with fstests will quickly find out a surprise that their config is not being parsed correctly until later. Fix this by preventing bringup if the prefix has a dash. We use the dash to help parallelize testing filesystem profiles and so the host prefix goes before the filesystem name and test profile. Signed-off-by: Luis Chamberlain Reported-by: Scott Mayhew Signed-off-by: Luis Chamberlain --- playbooks/roles/gen_nodes/tasks/main.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/playbooks/roles/gen_nodes/tasks/main.yml b/playbooks/roles/gen_nodes/tasks/main.yml index d541dcbf1f54..8c6a1f705ee2 100644 --- a/playbooks/roles/gen_nodes/tasks/main.yml +++ b/playbooks/roles/gen_nodes/tasks/main.yml @@ -18,6 +18,11 @@ command: "id -g -n" register: my_group +- name: Fail if kdevops_host_prefix contains a dash + fail: + msg: "Invalid kdevops_host_prefix '{{ kdevops_host_prefix }}'. The prefix cannot contain a dash ('-')." + when: kdevops_host_prefix is search("-") + - name: Create guestfs directory ansible.builtin.file: path: "{{ guestfs_path }}"