mbox series

[v2,0/3] Add support for x509 certs with NIST p256 and p192 keys

Message ID 20210126191115.434842-1-stefanb@linux.vnet.ibm.com (mailing list archive)
Headers show
Series Add support for x509 certs with NIST p256 and p192 keys | expand


Stefan Berger Jan. 26, 2021, 7:11 p.m. UTC
From: Stefan Berger <stefanb@linux.ibm.com>

This series of patches adds support for x509 certificates signed by a CA
that uses NIST p256 or p192 keys for signing. It also adds support for
certificates where the public key is a NIST p256 or p192 key. The math
for ECDSA signature verification is also added.

Since self-signed certificates are verified upon loading, the following
script can be used for testing:

keyctrl newring test @u

while :; do
	for hash in sha1 sha224 sha256 sha384 sha512; do
		openssl req \
			-x509 \
			-${hash} \
			-newkey ec \
			-pkeyopt ec_paramgen_curve:prime256v1 \
			-keyout key.pem \
			-days 365 \
			-subj '/CN=test' \
			-nodes \
			-outform der \
			-out cert.der
		keyctl padd asymmetric testkey %keyring:test < cert.der
		if [ $? -ne 0 ]; then
			echo "ERROR"
			exit 1

It also works with restricted keyrings where an RSA key is used to sign
a NIST P256/P192 key. Scripts for testing are here:


The ECDSA signature verification will be used by IMA Appraisal where ECDSA
file signatures stored in RPM packages will use substantially less space
than if RSA signatures were to be used.


  - using faster vli_sub rather than newly added vli_mod_fast to 'reduce'
  - rearranged switch statements to follow after RSA
  - 3rd patch from 1st posting is now 1st patch

Stefan Berger (3):
  x509: Detect sm2 keys by their parameters OID
  x509: Add support for parsing x509 certs with NIST p256 keys
  x509: Add support for NIST p192 keys in certificates and akcipher

 crypto/Makefile                           |   9 +-
 crypto/asymmetric_keys/public_key.c       |  19 ++
 crypto/asymmetric_keys/x509_cert_parser.c |  45 ++-
 crypto/ecc.c                              | 317 ++++++++++++++++++++++
 crypto/ecc.h                              |   2 +
 crypto/ecc_curve_defs.h                   |   4 +
 crypto/eccsignature.asn1                  |   4 +
 include/linux/oid_registry.h              |   6 +
 8 files changed, 403 insertions(+), 3 deletions(-)
 create mode 100644 crypto/eccsignature.asn1


David Howells Jan. 27, 2021, 9:17 a.m. UTC | #1
Stefan Berger <stefanb@linux.vnet.ibm.com> wrote:

> keyctrl newring test @u

This should be keyctl, and I would recommend you do:

	k=`keyctl newring test @u`

and then use $k for it.

You also need:

	#include <linux/scatterlist.h>

in ecc.c in the middle patch.