mbox series

[v2,00/11] kbuild: do not quote string values in Makefile

Message ID 20211214025355.1267796-1-masahiroy@kernel.org (mailing list archive)
Headers show
Series kbuild: do not quote string values in Makefile | expand

Message

Masahiro Yamada Dec. 14, 2021, 2:53 a.m. UTC
This patch refactors the code as outlined in:

  https://lore.kernel.org/linux-kbuild/CAK7LNAR-VXwHFEJqCcrFDZj+_4+Xd6oynbj_0eS8N504_ydmyw@mail.gmail.com/

First some patches refactor certs/Makefile. This Makefile is written
in a too complicated way.

I will revert cd8c917a56f20f48748dd43d9ae3caff51d5b987
after this lands in the upstream.



Masahiro Yamada (11):
  certs: use $< and $@ to simplify the key generation rule
  certs: unify duplicated cmd_extract_certs and improve the log
  certs: remove unneeded -I$(srctree) option for system_certificates.o
  certs: refactor file cleaning
  certs: remove misleading comments about GCC PR
  kbuild: stop using config_filename in scripts/Makefile.modsign
  certs: simplify $(srctree)/ handling and remove config_filename macro
  kbuild: do not include include/config/auto.conf from shell scripts
  kbuild: do not quote string values in include/config/auto.conf
  certs: move scripts/extract-cert to certs/
  microblaze: use built-in function to get CPU_{MAJOR,MINOR,REV}

 MAINTAINERS                                   |  1 -
 Makefile                                      |  6 +-
 arch/arc/Makefile                             |  4 +-
 arch/arc/boot/dts/Makefile                    |  4 +-
 arch/h8300/boot/dts/Makefile                  |  6 +-
 arch/microblaze/Makefile                      |  8 +--
 arch/nds32/boot/dts/Makefile                  |  7 +--
 arch/nios2/boot/dts/Makefile                  |  2 +-
 arch/openrisc/boot/dts/Makefile               |  7 +--
 arch/powerpc/boot/Makefile                    |  2 +-
 arch/riscv/boot/dts/canaan/Makefile           |  4 +-
 arch/sh/boot/dts/Makefile                     |  4 +-
 arch/xtensa/Makefile                          |  2 +-
 arch/xtensa/boot/dts/Makefile                 |  5 +-
 certs/.gitignore                              |  1 +
 certs/Makefile                                | 55 +++++++------------
 {scripts => certs}/extract-cert.c             |  2 +-
 drivers/acpi/Makefile                         |  2 +-
 drivers/base/firmware_loader/builtin/Makefile |  4 +-
 init/Makefile                                 |  2 +-
 net/wireless/Makefile                         |  4 +-
 scripts/.gitignore                            |  1 -
 scripts/Kbuild.include                        | 47 ----------------
 scripts/Makefile                              | 11 +---
 scripts/Makefile.modinst                      |  4 +-
 scripts/gen_autoksyms.sh                      | 11 +---
 scripts/kconfig/confdata.c                    |  2 +-
 scripts/link-vmlinux.sh                       | 47 ++++++++--------
 scripts/remove-stale-files                    |  2 +
 scripts/setlocalversion                       |  9 ++-
 usr/Makefile                                  |  2 +-
 31 files changed, 87 insertions(+), 181 deletions(-)
 rename {scripts => certs}/extract-cert.c (98%)

Comments

Masahiro Yamada Jan. 4, 2022, 11:48 p.m. UTC | #1
On Tue, Dec 14, 2021 at 11:55 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
>
> This patch refactors the code as outlined in:
>
>   https://lore.kernel.org/linux-kbuild/CAK7LNAR-VXwHFEJqCcrFDZj+_4+Xd6oynbj_0eS8N504_ydmyw@mail.gmail.com/
>
> First some patches refactor certs/Makefile. This Makefile is written
> in a too complicated way.
>
> I will revert cd8c917a56f20f48748dd43d9ae3caff51d5b987
> after this lands in the upstream.
>
>



Applied to linux-kbuild.



> Masahiro Yamada (11):
>   certs: use $< and $@ to simplify the key generation rule
>   certs: unify duplicated cmd_extract_certs and improve the log
>   certs: remove unneeded -I$(srctree) option for system_certificates.o
>   certs: refactor file cleaning
>   certs: remove misleading comments about GCC PR
>   kbuild: stop using config_filename in scripts/Makefile.modsign
>   certs: simplify $(srctree)/ handling and remove config_filename macro
>   kbuild: do not include include/config/auto.conf from shell scripts
>   kbuild: do not quote string values in include/config/auto.conf
>   certs: move scripts/extract-cert to certs/
>   microblaze: use built-in function to get CPU_{MAJOR,MINOR,REV}
>
>  MAINTAINERS                                   |  1 -
>  Makefile                                      |  6 +-
>  arch/arc/Makefile                             |  4 +-
>  arch/arc/boot/dts/Makefile                    |  4 +-
>  arch/h8300/boot/dts/Makefile                  |  6 +-
>  arch/microblaze/Makefile                      |  8 +--
>  arch/nds32/boot/dts/Makefile                  |  7 +--
>  arch/nios2/boot/dts/Makefile                  |  2 +-
>  arch/openrisc/boot/dts/Makefile               |  7 +--
>  arch/powerpc/boot/Makefile                    |  2 +-
>  arch/riscv/boot/dts/canaan/Makefile           |  4 +-
>  arch/sh/boot/dts/Makefile                     |  4 +-
>  arch/xtensa/Makefile                          |  2 +-
>  arch/xtensa/boot/dts/Makefile                 |  5 +-
>  certs/.gitignore                              |  1 +
>  certs/Makefile                                | 55 +++++++------------
>  {scripts => certs}/extract-cert.c             |  2 +-
>  drivers/acpi/Makefile                         |  2 +-
>  drivers/base/firmware_loader/builtin/Makefile |  4 +-
>  init/Makefile                                 |  2 +-
>  net/wireless/Makefile                         |  4 +-
>  scripts/.gitignore                            |  1 -
>  scripts/Kbuild.include                        | 47 ----------------
>  scripts/Makefile                              | 11 +---
>  scripts/Makefile.modinst                      |  4 +-
>  scripts/gen_autoksyms.sh                      | 11 +---
>  scripts/kconfig/confdata.c                    |  2 +-
>  scripts/link-vmlinux.sh                       | 47 ++++++++--------
>  scripts/remove-stale-files                    |  2 +
>  scripts/setlocalversion                       |  9 ++-
>  usr/Makefile                                  |  2 +-
>  31 files changed, 87 insertions(+), 181 deletions(-)
>  rename {scripts => certs}/extract-cert.c (98%)
>
> --
> 2.32.0
>